Skip to content

Commit ec68c99

Browse files
committed
(MAINT) Remove version constraints on rubocop
Prior to this commit Rubocop was constrained to an older version. This was causing cop errors when executed with newer rubies. This commit removes the version constraint from the Gemfile and bumps the target ruby version in rubocops config to 2.5 which is the current minimum supported version.
1 parent 234fc65 commit ec68c99

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.rubocop.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ require: rubocop-performance
22
inherit_from: .rubocop_todo.yml
33

44
AllCops:
5-
TargetRubyVersion: 2.3
5+
TargetRubyVersion: 2.5
66
Exclude:
77
# Ignore HTML related things
88
- '**/*.erb'
@@ -29,7 +29,7 @@ Lint/ElseLayout:
2929
Lint/UnreachableCode:
3030
Enabled: true
3131

32-
Lint/UselessComparison:
32+
Lint/BinaryOperatorWithIdenticalOperands:
3333
Enabled: true
3434

3535
# MAYBE useful - no return inside ensure block.
@@ -201,7 +201,7 @@ Style/WordArray:
201201
Style/RedundantPercentQ:
202202
Enabled: false
203203

204-
Layout/Tab:
204+
Layout/IndentationStyle:
205205
Enabled: false
206206

207207
Layout/SpaceBeforeSemicolon:
@@ -511,7 +511,7 @@ Layout/MultilineMethodCallBraceLayout:
511511
Layout/MultilineBlockLayout:
512512
Enabled: false
513513

514-
Lint/UselessAssignment:
514+
Lint/BinaryOperatorWithIdenticalOperands:
515515
Enabled: false
516516

517517
Lint/DuplicateMethods:

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ group :development do
3939
gem 'pry-byebug'
4040
end
4141

42-
gem 'rubocop', '~> 0.81.0' # last release that supports Ruby 2.3.0
42+
gem 'rubocop'
4343
gem 'rubocop-rspec'
4444
gem 'rubocop-performance'
4545

0 commit comments

Comments
 (0)