haproxy::backend: Always set $_sort_options_alphabetic

bastelfreak · bastelfreak · commit 73081e86d7bc · 2023-09-12T11:08:37.000+02:00
Without this there's a possiblity that the variable isn't defined. This
leads to an unreferenced variable call in line 133.
diff --git a/manifests/backend.pp b/manifests/backend.pp
@@ -113,6 +113,8 @@
       if ('httpchk' in $options['option']) {
         warning('Overriding the value of $sort_options_alphabetic to "false" due to "httpchk" option defined')
         $_sort_options_alphabetic = false
+      } else {
+        $_sort_options_alphabetic = $picked_sort_options_alphabetic
       }
     } else {
       $_sort_options_alphabetic = $picked_sort_options_alphabetic

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,8 @@`
`113`	`113`	`if ('httpchk' in $options['option']) {`
`114`	`114`	`warning('Overriding the value of $sort_options_alphabetic to "false" due to "httpchk" option defined')`
`115`	`115`	`$_sort_options_alphabetic = false`
	`116`	`+ } else {`
	`117`	`+ $_sort_options_alphabetic = $picked_sort_options_alphabetic`
`116`	`118`	`}`
`117`	`119`	`} else {`
`118`	`120`	`$_sort_options_alphabetic = $picked_sort_options_alphabetic`