Rework the mysql initdb functionality.

This reworks a previously unmerged PR to clean up the code a little and
adds a test for it.

Author: Ashley Penney

manifests/server/install.pp

@@ -6,16 +6,17 @@
     name   => $mysql::server::package_name,
   }
 
-  # run mysql_install_db if datadir is set and datadir doesn't contain the
-  # mysql database (directory)
+  # Build the initial databases.
   if $mysql::server::override_options['mysqld'] and $mysql::server::override_options['mysqld']['datadir'] {
     $mysqluser = $mysql::server::options['mysqld']['user']
     $datadir = $mysql::server::override_options['mysqld']['datadir']
 
-    exec { "mysql_install_db":
-      command => "mysql_install_db --datadir=$datadir --user=$mysqluser",
-      creates => "$datadir/mysql",
+    exec { 'mysql_install_db':
+      command   => "mysql_install_db --datadir=${datadir} --user=${mysqluser}",
+      creates   => "${datadir}/mysql",
       logoutput => on_failure,
+      path      => '/bin:/sbin:/usr/bin:/usr/sbin',
+      require   => Package['mysql-server'],
     }
   }
 

spec/acceptance/mysql_server_spec.rb

@@ -285,4 +285,20 @@ class { 'mysql::server':
     end
   end
 
+  describe 'creates the appropriate databases when datadir is set' do
+    tmpdir = default.tmpdir('mysql')
+    it 'sets up mysql' do
+      pp = <<-EOS
+      class { 'mysql::server':
+        override_options => { 'mysqld' => { 'datadir' => '#{tmpdir}/mysql' }},
+      }
+      EOS
+      shell("mkdir -p #{tmpdir}; chown -R mysql:mysql #{tmpdir}")
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file("#{tmpdir}/mysql/mysql") do
+      it { should be_directory }
+    end
+  end
 end

spec/acceptance/nodesets/default.yml

@@ -2,6 +2,7 @@ HOSTS:
   centos-64-x64:
     roles:
       - master
+      - default
     platform: el-6-x86_64
     box : centos-64-x64-vbox4210-nocm
     box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-64-x64-vbox4210-nocm.box