Skip to content

Commit 65de49f

Browse files
committed
Merge pull request #74 from jmchilton/specify_engine
Allow consumer to specify default storage engine for MySQL server.
2 parents 360f8d9 + 41be95e commit 65de49f

File tree

3 files changed

+21
-13
lines changed

3 files changed

+21
-13
lines changed

manifests/config.pp

+2-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@
4343
$ssl_ca = $mysql::params::ssl_ca,
4444
$ssl_cert = $mysql::params::ssl_cert,
4545
$ssl_key = $mysql::params::ssl_key,
46-
$log_error = $mysql::params::log_error
46+
$log_error = $mysql::params::log_error,
47+
$default_engine = 'UNSET'
4748
) inherits mysql::params {
4849

4950
File {

spec/classes/mysql_config_spec.rb

+16-11
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
:port => '3306',
1010
:etc_root_password => false,
1111
:datadir => '/var/lib/mysql',
12+
:default_engine => 'UNSET',
1213
:ssl => false,
1314
:ssl_ca => '/etc/mysql/cacert.pem',
1415
:ssl_cert => '/etc/mysql/server-cert.pem',
@@ -74,17 +75,18 @@
7475
[
7576
{},
7677
{
77-
:service_name => 'dans_service',
78-
:config_file => '/home/dan/mysql.conf',
79-
:service_name => 'dans_mysql',
80-
:socket => '/home/dan/mysql.sock',
81-
:bind_address => '0.0.0.0',
82-
:port => '3306',
83-
:datadir => '/path/to/datadir',
84-
:ssl => true,
85-
:ssl_ca => '/path/to/cacert.pem',
86-
:ssl_cert => '/path/to/server-cert.pem',
87-
:ssl_key => '/path/to/server-key.pem'
78+
:service_name => 'dans_service',
79+
:config_file => '/home/dan/mysql.conf',
80+
:service_name => 'dans_mysql',
81+
:socket => '/home/dan/mysql.sock',
82+
:bind_address => '0.0.0.0',
83+
:port => '3306',
84+
:datadir => '/path/to/datadir',
85+
:default_engine => 'InnoDB',
86+
:ssl => true,
87+
:ssl_ca => '/path/to/cacert.pem',
88+
:ssl_cert => '/path/to/server-cert.pem',
89+
:ssl_key => '/path/to/server-key.pem'
8890
}
8991
].each do |passed_params|
9092

@@ -140,6 +142,9 @@
140142
"datadir = #{param_values[:datadir]}",
141143
"bind-address = #{param_values[:bind_address]}"
142144
]
145+
if param_values[:default_engine] != 'UNSET'
146+
expected_lines = expected_lines | [ "default-storage-engine = #{param_values[:default_engine]}" ]
147+
end
143148
if param_values[:ssl]
144149
expected_lines = expected_lines |
145150
[

templates/my.cnf.erb

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ query_cache_size = 16M
2323
log_error = <%= log_error %>
2424
expire_logs_days = 10
2525
max_binlog_size = 100M
26-
26+
<% if default_engine != 'UNSET' %>
27+
default-storage-engine = <%= default_engine %>
28+
<% end %>
2729
<% if ssl == true %>
2830
ssl-ca = <%= ssl_ca %>
2931
ssl-cert = <%= ssl_cert %>

0 commit comments

Comments
 (0)