MODULES-10023 fix xtrabackup tests on SLES, RHEL 8 and RHEL/CentOS 5

Author: fraenki

manifests/params.pp

@@ -54,6 +54,9 @@
         /^(RedHat|CentOS|Scientific|OracleLinux)$/: {
           if versioncmp($::operatingsystemmajrelease, '7') >= 0 {
             $provider = 'mariadb'
+            if versioncmp($::operatingsystemmajrelease, '8') >= 0 {
+              $xtrabackup_package_name_override = 'percona-xtrabackup-24'
+            }
           } else {
             $provider = 'mysql'
             $xtrabackup_package_name_override = 'percona-xtrabackup-20'
@@ -153,6 +156,7 @@
       $root_group          = 'root'
       $mysql_group         = 'mysql'
       $server_service_name = 'mysql'
+      $xtrabackup_package_name_override = 'xtrabackup'
 
       if $::operatingsystem =~ /(SLES|SLED)/ {
         if versioncmp( $::operatingsystemmajrelease, '12' ) >= 0 {

spec/acceptance/mysql_backup_spec.rb

@@ -166,10 +166,17 @@ class { 'mysql::server': root_password => 'password' }
               }
             }
             /RedHat/: {
+              # RHEL/CentOS 5 is no longer supported by Percona, but older versions
+              # of the repository are still available.
+              if versioncmp($::operatingsystemmajrelease, '6') >= 0 {
+                $percona_url = 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm'
+              } else {
+                $percona_url = 'http://repo.percona.com/yum/release/5/os/noarch/percona-release-0.1-5.noarch.rpm'
+              }
               ensure_packages('percona-release',{
                 ensure   => present,
                 provider => 'rpm',
-                source   => 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm',
+                source   => $percona_url,
               })
               ensure_packages('epel-release',{
                 ensure   => present,
@@ -279,10 +286,17 @@ class { 'mysql::server': root_password => 'password' }
               }
             }
             /RedHat/: {
+              # RHEL/CentOS 5 is no longer supported by Percona, but older versions
+              # of the repository are still available.
+              if versioncmp($::operatingsystemmajrelease, '6') >= 0 {
+                $percona_url = 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm'
+              } else {
+                $percona_url = 'http://repo.percona.com/yum/release/5/os/noarch/percona-release-0.1-5.noarch.rpm'
+              }
               ensure_packages('percona-release',{
                 ensure   => present,
                 provider => 'rpm',
-                source   => 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm',
+                source   => $percona_url,
               })
               ensure_packages('epel-release',{
                 ensure   => present,

spec/classes/mysql_backup_xtrabackup_spec.rb

@@ -28,7 +28,9 @@ class { 'mysql::server': }
         end
 
         package = if facts[:osfamily] == 'RedHat'
-                    if Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '7') >= 0
+                    if Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '8') >= 0
+                      'percona-xtrabackup-24'
+                    elsif Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '7') >= 0
                       'percona-xtrabackup'
                     else
                       'percona-xtrabackup-20'
@@ -41,6 +43,8 @@ class { 'mysql::server': }
                     else
                       'percona-xtrabackup-24'
                     end
+                  elsif facts[:osfamily] == 'Suse'
+                    'xtrabackup'
                   else
                     'percona-xtrabackup'
                   end
@@ -109,7 +113,9 @@ class { 'mysql::server': }
         end
 
         package = if facts[:osfamily] == 'RedHat'
-                    if Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '7') >= 0
+                    if Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '8') >= 0
+                      'percona-xtrabackup-24'
+                    elsif Puppet::Util::Package.versioncmp(facts[:operatingsystemmajrelease], '7') >= 0
                       'percona-xtrabackup'
                     else
                       'percona-xtrabackup-20'
@@ -122,6 +128,8 @@ class { 'mysql::server': }
                     else
                       'percona-xtrabackup-24'
                     end
+                  elsif facts[:osfamily] == 'Suse'
+                    'xtrabackup'
                   else
                     'percona-xtrabackup'
                   end