(fix) - Fix an issue were we assume triggers work

- There are older versions of mysql that do not support the privilege TRIGGER and need to change default to not include
  http://dev.mysql.com/doc/refman/5.0/en/grant.html
  'MySQL does not support the standard SQL UNDER privilege, and does not support the TRIGGER privilege until MySQL 5.1.6'

- Updated tests to have both 5.1.6 and 5.0.11 tests for mysql_version fact

Author: Travis Fields

manifests/backup/mysqldump.pp

@@ -26,8 +26,7 @@
     require       => Class['mysql::server::root_password'],
   }
 
-
-  if $include_triggers {
+  if $include_triggers and versioncmp($::mysql_version, '5.1.5') > 0 {
     $privs = [ 'SELECT', 'RELOAD', 'LOCK TABLES', 'SHOW VIEW', 'PROCESS', 'TRIGGER' ]
   } else {
     $privs = [ 'SELECT', 'RELOAD', 'LOCK TABLES', 'SHOW VIEW', 'PROCESS' ]

spec/classes/mysql_server_backup_spec.rb

@@ -4,7 +4,7 @@
   on_pe_supported_platforms(PLATFORMS).each do |pe_version,pe_platforms|
     pe_platforms.each do |pe_platform,facts|
       describe "on #{pe_version} #{pe_platform}" do
-        let(:facts) { facts }
+        let(:facts) { {'mysql_version' => '5.1.6'}.merge(facts) }
 
         let(:default_params) {
           { 'backupuser'         => 'testuser',
@@ -26,7 +26,12 @@
           it { is_expected.to contain_mysql_grant('testuser@localhost/*.*').with(
             :privileges => ['SELECT', 'RELOAD', 'LOCK TABLES', 'SHOW VIEW', 'PROCESS', 'TRIGGER']
           ).that_requires('Mysql_user[testuser@localhost]') }
-
+          context 'mysql < 5.1.6' do
+            let(:facts) { {'mysql_version' => '5.0.95'}.merge(facts) }
+            it { is_expected.to contain_mysql_grant('testuser@localhost/*.*').with(
+               :privileges => ['SELECT', 'RELOAD', 'LOCK TABLES', 'SHOW VIEW', 'PROCESS']
+               ).that_requires('Mysql_user[testuser@localhost]') }
+          end
           context 'with triggers excluded' do
             let(:params) do
               { :include_triggers => false }.merge(default_params)
@@ -275,6 +280,15 @@
                 /ADDITIONAL_OPTIONS="\$ADDITIONAL_OPTIONS --triggers"/
               )
             end
+            describe 'mysql_version < 5.0.11' do
+              let(:facts) { facts.merge({'mysql_version' => '5.0.10'}) }
+              it 'should backup triggers when asked' do
+                is_expected.to contain_file('mysqlbackup.sh').with_content(
+                   /ADDITIONAL_OPTIONS="\$ADDITIONAL_OPTIONS --triggers"/
+                )
+              end
+            end
+
           end
 
           context 'with include_triggers set to false' do