Skip to content

Commit 8e24162

Browse files
author
Morgan Haskel
committed
Merge pull request #619 from cmurphy/master
Update .travis.yml, Gemfile, Rakefile, and CONTRIBUTING.md
2 parents 619fa7c + e8708f2 commit 8e24162

File tree

4 files changed

+10
-22
lines changed

4 files changed

+10
-22
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
language: ruby
3-
bundler_args: --without development
3+
bundler_args: --without system_tests
44
script: "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--format documentation'"
55
matrix:
66
fast_finish: true

CONTRIBUTING.md

+4-18
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,9 @@ Checklist (and a short version for the impatient)
4141

4242
* Pre-requisites:
4343

44-
- Sign the [Contributor License Agreement](https://cla.puppetlabs.com/)
45-
4644
- Make sure you have a [GitHub account](https://github.com/join)
4745

48-
- [Create a ticket](http://projects.puppetlabs.com/projects/modules/issues/new), or [watch the ticket](http://projects.puppetlabs.com/projects/modules/issues) you are patching for.
46+
- [Create a ticket](https://tickets.puppetlabs.com/secure/CreateIssue!default.jspa), or [watch the ticket](https://tickets.puppetlabs.com/browse/) you are patching for.
4947

5048
* Preferred method:
5149

@@ -94,17 +92,7 @@ The long version
9492
whitespace or other "whitespace errors". You can do this by
9593
running "git diff --check" on your changes before you commit.
9694

97-
2. Sign the Contributor License Agreement
98-
99-
Before we can accept your changes, we do need a signed Puppet
100-
Labs Contributor License Agreement (CLA).
101-
102-
You can access the CLA via the [Contributor License Agreement link](https://cla.puppetlabs.com/)
103-
104-
If you have any questions about the CLA, please feel free to
105-
contact Puppet Labs via email at [email protected].
106-
107-
3. Sending your patches
95+
2. Sending your patches
10896

10997
To submit your changes via a GitHub pull request, we _highly_
11098
recommend that you have them on a topic branch, instead of
@@ -124,7 +112,7 @@ The long version
124112
in order to open a pull request.
125113

126114

127-
4. Update the related GitHub issue.
115+
3. Update the related GitHub issue.
128116

129117
If there is a GitHub issue associated with the change you
130118
submitted, then you should update the ticket to include the
@@ -220,14 +208,12 @@ review.
220208
Additional Resources
221209
====================
222210

223-
* [Getting additional help](http://projects.puppetlabs.com/projects/puppet/wiki/Getting_Help)
211+
* [Getting additional help](http://puppetlabs.com/community/get-help)
224212

225213
* [Writing tests](http://projects.puppetlabs.com/projects/puppet/wiki/Development_Writing_Tests)
226214

227215
* [Patchwork](https://patchwork.puppetlabs.com)
228216

229-
* [Contributor License Agreement](https://projects.puppetlabs.com/contributor_licenses/sign)
230-
231217
* [General GitHub documentation](http://help.github.com/)
232218

233219
* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)

Gemfile

+4-2
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@ group :development, :unit_tests do
55
gem 'rspec-puppet', :require => false
66
gem 'puppetlabs_spec_helper', :require => false
77
gem 'puppet-lint', :require => false
8+
gem 'simplecov', :require => false
89
gem 'puppet_facts', :require => false
10+
gem 'json', :require => false
911
end
1012

1113
group :system_tests do
12-
gem 'beaker-rspec', :require => false
13-
gem 'serverspec', :require => false
14+
gem 'beaker-rspec', :require => false
15+
gem 'serverspec', :require => false
1416
end
1517

1618
if facterversion = ENV['FACTER_GEM_VERSION']

Rakefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ require 'puppetlabs_spec_helper/rake_tasks'
22
require 'puppet-lint/tasks/puppet-lint'
33

44
PuppetLint.configuration.fail_on_warnings
5+
PuppetLint.configuration.send('relative')
56
PuppetLint.configuration.send('disable_80chars')
67
PuppetLint.configuration.send('disable_class_inherits_from_params_class')
7-
PuppetLint.configuration.send('disable_class_parameter_defaults')
88
PuppetLint.configuration.send('disable_documentation')
99
PuppetLint.configuration.send('disable_single_quote_string_with_variables')
1010
PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]

0 commit comments

Comments
 (0)