Skip to content

Commit ad479e6

Browse files
committed
Changed backupdatabases default from false to []
1 parent 359d881 commit ad479e6

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

manifests/backup.pp

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
$backupcompress = true,
3434
$backuprotate = 30,
3535
$delete_before_dump = false,
36-
$backupdatabases = false,
36+
$backupdatabases = [],
3737
$ensure = 'present'
3838
) {
3939

templates/mysqlbackup.sh.erb

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ cleanup()
3131
cleanup
3232

3333
<% end -%>
34-
<% if @backupdatabases -%>
34+
<% if @backupdatabases.empty? -%>
35+
mysqldump -u${USER} -p${PASS} --opt --flush-logs --single-transaction \
36+
--all-databases <% if @backupcompress %>| bzcat -zc <% end %>> ${DIR}/${PREFIX}`date +%Y%m%d-%H%M%S`.sql<% if @backupcompress %>.bz2<% end %>
37+
<% else -%>
3538
<% @backupdatabases.each do |db| -%>
3639
mysqldump -u${USER} -p${PASS} --opt --flush-logs --single-transaction \
3740
<%= db %><% if @backupcompress %>| bzcat -zc <% end %>> ${DIR}/${PREFIX}<%= db %>_`date +%Y%m%d-%H%M%S`.sql<% if @backupcompress %>.bz2<% end %>
3841
<% end -%>
39-
<% else -%>
40-
mysqldump -u${USER} -p${PASS} --opt --flush-logs --single-transaction \
41-
--all-databases <% if @backupcompress %>| bzcat -zc <% end %>> ${DIR}/${PREFIX}`date +%Y%m%d-%H%M%S`.sql<% if @backupcompress %>.bz2<% end %>
4242
<% end -%>
4343

4444
<% unless @delete_before_dump -%>

0 commit comments

Comments
 (0)