Use the new fact for version discovery.

Author: jtopper

lib/puppet/provider/mysql.rb

@@ -33,7 +33,7 @@ def mysqld_type
   def self.mysqld_version_string
     # we cache the result ...
     return @mysqld_version_string unless @mysqld_version_string.nil?
-    @mysqld_version_string = mysqld(['-V'].compact)
+    @mysqld_version_string = Facter.value(:mysqld_version)
     return @mysqld_version_string
   end
 

spec/unit/puppet/provider/mysql_user/mysql_spec.rb

@@ -200,10 +200,15 @@
   end
 
   describe 'self.mysqld_version' do
-    it 'queries mysql if unset' do
+    it 'uses the mysqld_version fact if unset' do
        provider.class.instance_variable_set(:@mysqld_version_string, nil)
-       provider.class.expects(:mysqld).with(['-V'])
-       expect(provider.mysqld_version).to be_nil
+       Facter.stubs(:value).with(:mysqld_version).returns('5.6.24')
+       expect(provider.mysqld_version).to eq '5.6.24'
+    end
+    it 'returns nil if the mysqld_version fact is absent' do
+       provider.class.instance_variable_set(:@mysqld_version_string, nil)
+       Facter.stubs(:value).with(:mysqld_version).returns(nil)
+       expect(provider.mysqld_version).to eq nil
     end
     it 'returns 5.7.6 for "mysqld  Ver 5.7.6 for Linux on x86_64 (MySQL Community Server (GPL))"' do
        provider.class.instance_variable_set(:@mysqld_version_string, 'mysqld  Ver 5.7.6 for Linux on x86_64 (MySQL Community Server (GPL))')