Prefer $facts[...] to $::...

smortex · smortex · commit f67ca52d6b12 · 2023-02-15T09:07:42.000-10:00
diff --git a/manifests/server/root_password.pp b/manifests/server/root_password.pp
@@ -46,7 +46,7 @@
     }
 
     # show_diff was added with puppet 3.0
-    if versioncmp($::puppetversion, '3.0') >= 0 {
+    if versioncmp($facts['puppetversion'], '3.0') >= 0 {
       File["${::root_home}/.my.cnf"] { show_diff => false }
     }
     if $mysql::server::create_root_user {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`# show_diff was added with puppet 3.0`
`49`		`- if versioncmp($::puppetversion, '3.0') >= 0 {`
	`49`	`+ if versioncmp($facts['puppetversion'], '3.0') >= 0 {`
`50`	`50`	`File["${::root_home}/.my.cnf"] { show_diff => false }`
`51`	`51`	`}`
`52`	`52`	`if $mysql::server::create_root_user {`