Skip to content

Commit 982a957

Browse files
Fix warnings revealed by v0.14.1 PS release (#112)
1 parent 89b6c7d commit 982a957

File tree

7 files changed

+17
-6
lines changed

7 files changed

+17
-6
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ New features:
1111
Bugfixes:
1212

1313
Other improvements:
14+
- Removed unused names found by v0.14.1 PureScript release (#112 by @JordanMartinez)
15+
- Installed dependencies directly imported into source code that were previously installed transitively (#112 by @JordanMartinez)
1416

1517
## [v6.0.0](https://github.com/purescript-contrib/purescript-parsing/releases/tag/v6.0.0) - 2021-02-26
1618

spago.dhall

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,22 @@
33
[ "arrays"
44
, "assert"
55
, "console"
6+
, "control"
67
, "effect"
78
, "either"
89
, "foldable-traversable"
910
, "identity"
1011
, "integers"
1112
, "lists"
13+
, "math"
1214
, "maybe"
15+
, "newtype"
1316
, "prelude"
1417
, "psci-support"
1518
, "strings"
19+
, "tailrec"
1620
, "transformers"
21+
, "tuples"
1722
, "unicode"
1823
]
1924
, packages = ./packages.dhall

src/Text/Parsing/Parser.purs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,9 @@ derive newtype instance monadErrorParserT :: Monad m => MonadError ParseError (P
103103

104104
instance altParserT :: Monad m => Alt (ParserT s m) where
105105
alt p1 p2 = (ParserT <<< ExceptT <<< StateT) \(s@(ParseState i p _)) -> do
106-
Tuple e s'@(ParseState i' p' c') <- runStateT (runExceptT (unwrap p1)) (ParseState i p false)
106+
Tuple e s'@(ParseState _ _ c') <- runStateT (runExceptT (unwrap p1)) (ParseState i p false)
107107
case e of
108-
Left err
108+
Left _
109109
| not c' -> runStateT (runExceptT (unwrap p2)) s
110110
_ -> pure (Tuple e s')
111111

src/Text/Parsing/Parser/Combinators.purs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@ skipMany p = skipMany1 p <|> pure unit
186186
-- | Skip at least one instance of a phrase.
187187
skipMany1 :: forall s a m. Monad m => ParserT s m a -> ParserT s m Unit
188188
skipMany1 p = do
189-
x <- p
190-
xs <- skipMany p
189+
_ <- p
190+
_ <- skipMany p
191191
pure unit
192192

193193
-- | Fail if the specified parser matches.

src/Text/Parsing/Parser/Indent.purs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ module Text.Parsing.Indent
4848
, (<*/>)
4949
, indentOp
5050
, (<?/>)
51+
, indentBrackets
52+
, indentAngles
53+
, indentBraces
54+
, indentParens
5155
, Optional(..)
5256
) where
5357

src/Text/Parsing/Parser/Token.purs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ token tokpos = do
5656
case List.uncons input of
5757
Nothing -> fail "Unexpected EOF"
5858
Just { head, tail } -> do
59-
modify_ \(ParseState _ position _) ->
59+
modify_ \(ParseState _ _ _) ->
6060
ParseState tail (tokpos head) true
6161
pure head
6262

test/Main.purs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ main = do
500500

501501
case runParser "aa" p of
502502
Right _ -> assert' "error: ParseError expected!" false
503-
Left (ParseError message pos) -> do
503+
Left (ParseError message _) -> do
504504
let messageExpected = "context1 context2 Expected \"b\""
505505
assert' ("expected message: " <> messageExpected <> ", message: " <> message) (message == messageExpected)
506506
logShow messageExpected

0 commit comments

Comments
 (0)