Skip to content

Commit 8144c37

Browse files
Add null support for data property of InputEvent (#21)
* Add nullability support for data property of input events * Update changelog * Reference pull request in changelog
1 parent af889d2 commit 8144c37

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Notable changes to this project are documented in this file. The format is based
55
## [Unreleased]
66

77
Breaking changes:
8+
- Add null support for `data` property of `InputEvent` (#21)
89

910
New features:
1011

src/Web/UIEvent/InputEvent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export function data_(e) {
1+
export function _data_(e) {
22
return e.data;
33
}
44

src/Web/UIEvent/InputEvent.purs

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,19 @@
1-
module Web.UIEvent.InputEvent where
1+
module Web.UIEvent.InputEvent
2+
( InputEvent
3+
, data_
4+
, fromEvent
5+
, fromUIEvent
6+
, isComposing
7+
, toEvent
8+
, toUIEvent
9+
) where
10+
11+
import Prelude
212

313
import Prelude
414

515
import Data.Maybe (Maybe)
16+
import Data.Nullable (Nullable, toMaybe)
617
import Unsafe.Coerce (unsafeCoerce)
718
import Web.Event.Event (Event)
819
import Web.Internal.FFI (unsafeReadProtoTagged)
@@ -23,7 +34,10 @@ toUIEvent = unsafeCoerce
2334
toEvent :: InputEvent -> Event
2435
toEvent = unsafeCoerce
2536

26-
foreign import data_ :: InputEvent -> String
37+
foreign import _data_ :: InputEvent -> Nullable String
38+
39+
data_ :: InputEvent -> Maybe String
40+
data_ = toMaybe <$> _data_
2741

2842
foreign import isComposing :: InputEvent -> Boolean
2943

0 commit comments

Comments
 (0)