Skip to content

Commit 1652e4b

Browse files
authored
Removed xfail tests while testing mvnormal random
1 parent 25f6108 commit 1652e4b

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

pymc3/tests/test_distributions_random.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1571,7 +1571,7 @@ def test_Triangular(
15711571
assert prior["target"].shape == (prior_samples,) + shape
15721572

15731573

1574-
def generate_shapes(include_params=False, xfail=False):
1574+
def generate_shapes(include_params=False):
15751575
# fmt: off
15761576
mudim_as_event = [
15771577
[None, 1, 3, 10, (10, 3), 100],
@@ -1590,20 +1590,13 @@ def generate_shapes(include_params=False, xfail=False):
15901590
del mudim_as_event[-1]
15911591
del mudim_as_dist[-1]
15921592
data = itertools.chain(itertools.product(*mudim_as_event), itertools.product(*mudim_as_dist))
1593-
if xfail:
1594-
data = list(data)
1595-
for index in range(len(data)):
1596-
if data[index][0] in (None, 1):
1597-
data[index] = pytest.param(
1598-
*data[index], marks=pytest.mark.xfail(reason="wait for PR #4214")
1599-
)
16001593
return data
16011594

16021595

16031596
class TestMvNormal(SeededTest):
16041597
@pytest.mark.parametrize(
16051598
["sample_shape", "dist_shape", "mu_shape", "param"],
1606-
generate_shapes(include_params=True, xfail=False),
1599+
generate_shapes(include_params=True),
16071600
ids=str,
16081601
)
16091602
def test_with_np_arrays(self, sample_shape, dist_shape, mu_shape, param):
@@ -1613,7 +1606,7 @@ def test_with_np_arrays(self, sample_shape, dist_shape, mu_shape, param):
16131606

16141607
@pytest.mark.parametrize(
16151608
["sample_shape", "dist_shape", "mu_shape"],
1616-
generate_shapes(include_params=False, xfail=True),
1609+
generate_shapes(include_params=False),
16171610
ids=str,
16181611
)
16191612
def test_with_chol_rv(self, sample_shape, dist_shape, mu_shape):
@@ -1630,7 +1623,7 @@ def test_with_chol_rv(self, sample_shape, dist_shape, mu_shape):
16301623

16311624
@pytest.mark.parametrize(
16321625
["sample_shape", "dist_shape", "mu_shape"],
1633-
generate_shapes(include_params=False, xfail=True),
1626+
generate_shapes(include_params=False),
16341627
ids=str,
16351628
)
16361629
def test_with_cov_rv(self, sample_shape, dist_shape, mu_shape):

0 commit comments

Comments
 (0)