logp test, test rename, np.all - > np.any

Author: daniel-saunders-phil

pymc/distributions/multivariate.py

@@ -2078,7 +2078,7 @@ def rng_fn(cls, rng: np.random.RandomState, mu, W, alpha, tau, size):
         Journal of the Royal Statistical Society Series B, Royal Statistical Society,
         vol. 63(2), pages 325-338. DOI: 10.1111/1467-9868.00288
         """
-        if np.all(alpha >= 1) or np.all(alpha <= -1):
+        if np.any(alpha >= 1) or np.any(alpha <= -1):
             raise ValueError("the domain of alpha is: -1 < alpha < 1")
 
         if not scipy.sparse.issparse(W):

tests/distributions/test_multivariate.py

@@ -836,7 +836,7 @@ def test_car_matrix_check(sparse):
 
 
 @pytest.mark.parametrize("alpha", [1, -1])
-def test_car_alpha(alpha):
+def test_car_alpha_bounds(alpha):
     """
     Tests the check that -1 < alpha < 1
     """
@@ -845,12 +845,16 @@ def test_car_alpha(alpha):
 
     tau = 1
     mu = np.array([0, 0, 0])
+    values = np.array([-0.5, 0, 0.5])
 
     car_dist = pm.CAR.dist(W=W, alpha=alpha, mu=mu, tau=tau)
 
     with pytest.raises(ValueError, match="the domain of alpha is: -1 < alpha < 1"):
         pm.draw(car_dist)
 
+    with pytest.raises(ValueError, match="-1 < alpha < 1, tau > 0"):
+        pm.logp(car_dist, values).eval()
+
 
 class TestLKJCholeskCov:
     def test_dist(self):