Skip to content

Commit 717ae3d

Browse files
authored
Fix failing CI (#943)
* Fix flake8 config * Drop Codecov * Disable more rich markup in tests
1 parent bb51e46 commit 717ae3d

File tree

6 files changed

+12
-17
lines changed

6 files changed

+12
-17
lines changed

.flake8

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
max-line-length = 88
44

55
extend-ignore =
6-
D107, # Missing docstring in __init__
6+
# Missing docstring in __init__
7+
D107
78

8-
per-file-ignores =
9+
per-file-ignores =
910
# TODO: Incrementally add missing docstrings
1011
# D100 Missing docstring in public module
1112
# D101 Missing docstring in public class

.github/workflows/main.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,7 @@ jobs:
5252
- name: Run type-checking
5353
run: python -m tox -e types
5454
- name: Run tests
55-
run: python -m tox -e py -- --cov-report xml
56-
- uses: codecov/codecov-action@v1
57-
if: github.event_name != 'schedule'
58-
with:
59-
file: ./coverage.xml
60-
name: ${{ matrix.python-version }} - ${{ matrix.platform }}
61-
fail_ci_if_error: true
55+
run: python -m tox -e py
6256

6357
# Because the tests can be flaky, they shouldn't be required for merge, but
6458
# it's still helpful to run them on PRs. See:

README.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
.. image:: https://img.shields.io/github/workflow/status/pypa/twine/Main
1111
:target: https://github.com/pypa/twine/actions
1212

13-
.. image:: https://img.shields.io/codecov/c/github/pypa/twine
14-
:target: https://codecov.io/gh/pypa/twine
15-
1613
twine
1714
=====
1815

pytest.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,4 @@ filterwarnings=
66
ignore:the imp module is deprecated::setuptools
77

88
addopts =
9-
--cov=twine --cov-context=test --cov-report=
109
--disable-socket

tests/conftest.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ def configure_output():
2020
"""
2121
rich.reconfigure(
2222
no_color=True,
23+
color_system=None,
24+
emoji=False,
25+
highlight=False,
2326
width=500,
2427
)
2528

tox.ini

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@ isolated_build = True
77
deps =
88
pretend
99
pytest
10-
pytest-cov
1110
pytest-socket
1211
build
12+
coverage
1313
passenv =
1414
PYTEST_ADDOPTS
1515
commands =
16-
pytest --ignore-glob '*integration*.py' {posargs:--cov-report term-missing --cov-report html}
16+
python -m coverage run -m pytest --ignore-glob '*integration*.py'
17+
python -m coverage html --show-contexts
18+
python -m coverage report -m --fail-under 97
1719

1820
[testenv:integration]
1921
deps =
@@ -26,8 +28,7 @@ deps =
2628
passenv =
2729
PYTEST_ADDOPTS
2830
commands =
29-
# Skipping coverage because that should be handled by the other tests
30-
pytest -r aR --no-cov tests/test_integration.py
31+
pytest -r aR tests/test_integration.py
3132

3233
[testenv:docs]
3334
deps =

0 commit comments

Comments
 (0)