Skip to content

Commit c87bb27

Browse files
committed
it *should* work
1 parent 7f9868c commit c87bb27

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

Makefile.pre.in

+6-6
Original file line numberDiff line numberDiff line change
@@ -3313,17 +3313,17 @@ MODULE__HASHLIB_DEPS=$(srcdir)/Modules/hashlib.h
33133313
MODULE__IO_DEPS=$(srcdir)/Modules/_io/_iomodule.h
33143314

33153315
# HACL*-based cryptographic primitives
3316-
MODULE__MD5_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_MD5_HEADERS)
3316+
MODULE__MD5_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_MD5_HEADERS) $(LIBHACL_MD5_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33173317
MODULE__MD5_LDEPS=$(LIBHACL_MD5_LIB_@LIBHACL_LDEPS_LIBTYPE@)
3318-
MODULE__SHA1_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA1_HEADERS)
3318+
MODULE__SHA1_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA1_HEADERS) $(LIBHACL_SHA1_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33193319
MODULE__SHA1_LDEPS=$(LIBHACL_SHA1_LIB_@LIBHACL_LDEPS_LIBTYPE@)
3320-
MODULE__SHA2_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA2_HEADERS)
3320+
MODULE__SHA2_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA2_HEADERS) $(LIBHACL_SHA2_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33213321
MODULE__SHA2_LDEPS=$(LIBHACL_SHA2_LIB_@LIBHACL_LDEPS_LIBTYPE@)
3322-
MODULE__SHA3_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA3_HEADERS)
3322+
MODULE__SHA3_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_SHA3_HEADERS) $(LIBHACL_SHA3_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33233323
MODULE__SHA3_LDEPS=$(LIBHACL_SHA3_LIB_@LIBHACL_LDEPS_LIBTYPE@)
3324-
MODULE__BLAKE2_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_BLAKE2_HEADERS)
3324+
MODULE__BLAKE2_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_BLAKE2_HEADERS) $(LIBHACL_BLAKE2_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33253325
MODULE__BLAKE2_LDEPS=$(LIBHACL_BLAKE2_LIB_@LIBHACL_LDEPS_LIBTYPE@)
3326-
MODULE__HMAC_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_HMAC_HEADERS)
3326+
MODULE__HMAC_DEPS=$(srcdir)/Modules/hashlib.h $(LIBHACL_HMAC_HEADERS) $(LIBHACL_HMAC_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33273327
MODULE__HMAC_LDEPS=$(LIBHACL_HMAC_LIB_@LIBHACL_LDEPS_LIBTYPE@)
33283328

33293329
MODULE__SOCKET_DEPS=$(srcdir)/Modules/socketmodule.h $(srcdir)/Modules/addrinfo.h $(srcdir)/Modules/getaddrinfo.c $(srcdir)/Modules/getnameinfo.c

configure

+5-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

+5-3
Original file line numberDiff line numberDiff line change
@@ -7883,7 +7883,7 @@ case "$ac_sys_system" in
78837883
fi
78847884
;;
78857885
esac
7886-
LIBHACL_CFLAGS="\$(CCSHARED) ${LIBHACL_FLAG_I} ${LIBHACL_FLAG_D}"
7886+
LIBHACL_CFLAGS="${LIBHACL_FLAG_I} ${LIBHACL_FLAG_D} \$(PY_STDMODULE_CFLAGS) \$(CCSHARED)"
78877887
AC_SUBST([LIBHACL_CFLAGS])
78887888
LIBHACL_LDFLAGS= # for now, no specific linker flags are needed
78897889
AC_SUBST([LIBHACL_LDFLAGS])
@@ -7892,7 +7892,8 @@ AC_SUBST([LIBHACL_LDFLAGS])
78927892
# Android.
78937893
# The *mmintrin.h headers are x86-family-specific, so can't be used on WASI.
78947894
if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \
7895-
test -n "$ANDROID_API_LEVEL" -a "$ANDROID_API_LEVEL" -ge 28; then
7895+
{ test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; }
7896+
then
78967897
dnl This can be extended here to detect e.g. Power8, which HACL* should also support.
78977898
AX_CHECK_COMPILE_FLAG([-msse -msse2 -msse3 -msse4.1 -msse4.2],[
78987899
[LIBHACL_SIMD128_FLAGS="-msse -msse2 -msse3 -msse4.1 -msse4.2"]
@@ -7924,7 +7925,8 @@ AC_SUBST([LIBHACL_BLAKE2_SIMD128_OBJS])
79247925
# (https://developer.android.com/ndk/guides/abis#86-64), this is safe because we do a
79257926
# runtime CPUID check.
79267927
if test "$ac_sys_system" != "Linux-android" -a "$ac_sys_system" != "WASI" || \
7927-
test -n "$ANDROID_API_LEVEL" -a "$ANDROID_API_LEVEL" -ge 28; then
7928+
{ test -n "$ANDROID_API_LEVEL" && test "$ANDROID_API_LEVEL" -ge 28; }
7929+
then
79287930
AX_CHECK_COMPILE_FLAG([-mavx2],[
79297931
[LIBHACL_SIMD256_FLAGS="-mavx2"]
79307932
AC_DEFINE([HACL_CAN_COMPILE_SIMD256], [1], [HACL* library can compile SIMD256 implementations])

0 commit comments

Comments
 (0)