Update pcre target

Author: jackzhxng

targets.bzl

@@ -32,6 +32,9 @@ def define_common_targets():
             ("include", "pytorch/tokenizers/regex.h"),
             ("include", "pytorch/tokenizers/*_regex.h"),
         ]),
+	deps = [
+            "fbsource//third-party/pcre2:pcre2-8",
+        ],
         exported_deps = [
             ":headers",
         ],

third-party/targets.bzl

@@ -60,65 +60,54 @@ def define_common_targets():
             ],
         )
 
+        runtime.genrule(
+            name = "config_h_generic",
+            srcs = ["pcre2/src/config.h.generic"],
+            cmd = "cp $SRCS $OUT",
+            out = "pcre2/src/config.h",
+        )
+        runtime.genrule(
+            name = "pcre2_h_generic",
+            srcs = ["pcre2/src/pcre2.h.generic"],
+            cmd = "cp $SRCS $OUT",
+            out = "pcre2/src/pcre2.h",
+        )
+        runtime.genrule(
+            name = "pcre2_chartables_c",
+            srcs = ["pcre2/src/pcre2_chartables.c.dist"],
+            cmd = "cp $SRCS $OUT",
+            out = "pcre2/src/pcre2_chartables.c",
+        )
+
         runtime.cxx_library(
             name = "pcre2",
-            srcs = [
-                "src/pcre2_auto_possess.c",
-                "src/pcre2_chkdint.c",
-                "src/pcre2_compile.c",
-                "src/pcre2_compile_cgroup.c",
-                "src/pcre2_compile_class.c",
-                "src/pcre2_config.c",
-                "src/pcre2_context.c",
-                "src/pcre2_convert.c",
-                "src/pcre2_dfa_match.c",
-                "src/pcre2_error.c",
-                "src/pcre2_extuni.c",
-                "src/pcre2_find_bracket.c",
-                "src/pcre2_jit_compile.c",
-                "src/pcre2_maketables.c",
-                "src/pcre2_match.c",
-                "src/pcre2_match_data.c",
-                "src/pcre2_match_next.c",
-                "src/pcre2_newline.c",
-                "src/pcre2_ord2utf.c",
-                "src/pcre2_pattern_info.c",
-                "src/pcre2_script_run.c",
-                "src/pcre2_serialize.c",
-                "src/pcre2_string_utils.c",
-                "src/pcre2_study.c",
-                "src/pcre2_substitute.c",
-                "src/pcre2_substring.c",
-                "src/pcre2_tables.c",
-                "src/pcre2_ucd.c",
-                "src/pcre2_valid_utf.c",
-                "src/pcre2_xclass.c",
-                "src/pcre2_chartables.c",
+            srcs = glob([
+                "pcre2/src/*.c",
+            ]) + [
+                ":pcre2_chartables_c",
             ],
-            headers = [
-                "src/pcre2.h",
-                "src/pcre2_compile.h",
-                "src/pcre2_internal.h",
-                "src/pcre2_intmodedep.h",
-                "src/pcre2_jit_match_inc.h",
-                "src/pcre2_jit_misc_inc.h",
-                "src/pcre2_printint_inc.h",
-                "src/pcre2_ucp.h",
-                "src/pcre2_ucptables_inc.h",
-                "src/pcre2_util.h",
+            exported_headers = [
+                ":pcre2_h_generic",
             ],
-            header_namespace = "src",
-            defines = [
-                "HAVE_CONFIG_H",
-                "HAVE_MEMMOVE",
-                "HAVE_STRERROR",
-                "PCRE2_CODE_UNIT_WIDTH=8",
-                "PCpRE2_STATIC",
-                "SUPPORT_PCRE2_8",
-                "SUPPORT_UNICODE",
+            headers = [
+                ":config_h_generic",
+            ] + glob([
+                "pcre2/src/*.h",
+            ]),
+            # Preprocessor flags from https://github.com/PCRE2Project/pcre2/blob/2e03e323339ab692640626f02f8d8d6f95bff9c6/BUILD.bazel#L23.
+            preprocessor_flags = [
+                "-DHAVE_CONFIG_H",
+                "-DHAVE_MEMMOVE",
+                "-DHAVE_STRERROR",
+                "-DPCRE2_CODE_UNIT_WIDTH=8",
+                "-DPCRE2_STATIC",
+                "-DSUPPORT_PCRE2_8",
+                "-DSUPPORT_UNICODE",
             ] + select({
-                "DEFAULT": ["HAVE_UNISTD_H"],
-                "WINDOWS": [],
+                "DEFAULT": ["-DHAVE_UNISTD_H"],
+                "ovr_config//os:windows": [],
             }),
+            _is_external_target = True,
+            public_include_directories = ["pcre2"],
             visibility = ["PUBLIC"],
-        )
+        )