chore!: Updated the tensor names as per review comments

Signed-off-by: Anurag Dixit <[email protected]>

Author: andi4191

cpp/bin/torchtrtc/accuracy.cpp

@@ -19,13 +19,17 @@ bool check_rtol(const at::Tensor& diff, const std::vector<at::Tensor> inputs, fl
   return diff.abs().max().item<float>() <= threshold * maxValue;
 }
 
-bool almost_equal(const at::Tensor& a, const at::Tensor& b, float atol, float rtol) {
-  auto a_float = a.toType(at::kFloat);
-  auto b_float = b.toType(at::kFloat);
-
-  auto diff = a_float - b_float;
+bool almost_equal(
+    const at::Tensor& computed_tensor,
+    const at::Tensor& gt_tensor, // gt_tensor : Ground Truth Tensor
+    float atol,
+    float rtol) {
+  auto computed_tensor_float = computed_tensor.toType(at::kFloat);
+  auto gt_tensor_float = gt_tensor.toType(at::kFloat);
+
+  auto diff = computed_tensor_float - gt_tensor_float;
   auto result = diff.abs().max().item<float>();
-  auto threshold = atol + (rtol * b.abs().max().item<float>());
+  auto threshold = atol + (rtol * gt_tensor.abs().max().item<float>());
 
   torchtrt::logging::log(torchtrt::logging::Level::kDEBUG, std::string("Max Difference: ") + std::to_string(result));
   torchtrt::logging::log(

cpp/bin/torchtrtc/accuracy.h

@@ -12,7 +12,7 @@ namespace torchtrtc {
 namespace accuracy {
 
 bool check_rtol(const at::Tensor& diff, const std::vector<at::Tensor> inputs, float threshold);
-bool almost_equal(const at::Tensor& a, const at::Tensor& b, float atol = 1e-8, float rtol = 1e-5);
+bool almost_equal(const at::Tensor& computed_tensor, const at::Tensor& gt_tensor, float atol = 1e-8, float rtol = 1e-5);
 
 } // namespace accuracy
 } // namespace torchtrtc

cpp/bin/torchtrtc/main.cpp

@@ -440,14 +440,18 @@ int main(int argc, char** argv) {
       }
 
       for (size_t i = 0; i < trt_results.size(); i++) {
+        std::ostringstream threshold_ss;
+        threshold_ss << "atol: " << atol_val << " rtol: " << rtol_val;
         if (!torchtrtc::accuracy::almost_equal(
                 jit_results[i], trt_results[i].reshape_as(jit_results[i]), atol_val, rtol_val)) {
-          std::ostringstream threshold_ss;
-          threshold_ss << "atol: " << atol_val << " rtol: " << rtol_val;
           torchtrt::logging::log(
               torchtrt::logging::Level::kWARNING,
               std::string("Maximum numerical deviation for output exceeds tolerance thresholds (") +
                   threshold_ss.str() + std::string(")"));
+        } else {
+          torchtrt::logging::log(
+              torchtrt::logging::Level::kDEBUG,
+              std::string("Maximum numerical deviation within threshold limits ") + threshold_ss.str());
         }
       }
     } else {