fix: Fixing pybind error on nightly #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anurag Dixit <[email protected]>
andi4191
added
WIP
Signed-off-by: Anurag Dixit <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/py/torch_tensorrt/csrc/torch_tensorrt_py.cpp b/tmp/changes.txt
index 8e18dfa..4b87dea 100644
--- a/workspace/py/torch_tensorrt/csrc/torch_tensorrt_py.cpp
+++ b/tmp/changes.txt
@@ -25,11 +25,9 @@ class pyCalibratorTrampoline : public Derived {
int getBatchSize() const noexcept override {
try {
PYBIND11_OVERLOAD_PURE_NAME(int, Derived, "get_batch_size", getBatchSize);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_batch_size" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_batch_size");
}
return -1;
@@ -83,11 +81,9 @@ class pyIInt8Calibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Calibrato
try {
PYBIND11_OVERLOAD_PURE_NAME(
nvinfer1::CalibrationAlgoType, nvinfer1::IInt8Calibrator, "get_algorithm", getAlgorithm);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_algorithm: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_algorithm");
}
return {};
@@ -102,11 +98,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
double getQuantile() const noexcept override {
try {
PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_quantile", getQuantile);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_quantile: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_quantile");
}
return -1.0;
@@ -114,12 +108,11 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
double getRegressionCutoff() const noexcept override {
try {
- PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
- }
- catch(std::exception const &e) {
+ PYBIND11_OVERLOAD_PURE_NAME(
+ double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_regression_cutoff: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_regression_cutoff");
}
return -1.0;
@@ -129,11 +122,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
try {
PYBIND11_OVERLOAD_PURE_NAME(
const char*, nvinfer1::IInt8LegacyCalibrator, "read_histogram_cache", readHistogramCache, length);
- }
- catch(std::exception const& e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in read_histogram_cache" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in read_histogram_cache");
}
return {};
@@ -143,11 +134,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
try {
PYBIND11_OVERLOAD_PURE_NAME(
void, nvinfer1::IInt8LegacyCalibrator, "write_histogram_cache", writeHistogramCache, ptr, length);
- }
- catch(std::exception const& e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in write_histogram_cache" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in write_histogram_cache");
}
}
ERROR: Some files do not conform to style guidelines
andi4191
removed
the
WIP
andi4191
changed the title
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/py/torch_tensorrt/csrc/torch_tensorrt_py.cpp b/tmp/changes.txt
index 8e18dfa..4b87dea 100644
--- a/workspace/py/torch_tensorrt/csrc/torch_tensorrt_py.cpp
+++ b/tmp/changes.txt
@@ -25,11 +25,9 @@ class pyCalibratorTrampoline : public Derived {
int getBatchSize() const noexcept override {
try {
PYBIND11_OVERLOAD_PURE_NAME(int, Derived, "get_batch_size", getBatchSize);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_batch_size" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_batch_size");
}
return -1;
@@ -83,11 +81,9 @@ class pyIInt8Calibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Calibrato
try {
PYBIND11_OVERLOAD_PURE_NAME(
nvinfer1::CalibrationAlgoType, nvinfer1::IInt8Calibrator, "get_algorithm", getAlgorithm);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_algorithm: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_algorithm");
}
return {};
@@ -102,11 +98,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
double getQuantile() const noexcept override {
try {
PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_quantile", getQuantile);
- }
- catch(std::exception const &e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_quantile: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_quantile");
}
return -1.0;
@@ -114,12 +108,11 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
double getRegressionCutoff() const noexcept override {
try {
- PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
- }
- catch(std::exception const &e) {
+ PYBIND11_OVERLOAD_PURE_NAME(
+ double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_regression_cutoff: " + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in get_regression_cutoff");
}
return -1.0;
@@ -129,11 +122,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
try {
PYBIND11_OVERLOAD_PURE_NAME(
const char*, nvinfer1::IInt8LegacyCalibrator, "read_histogram_cache", readHistogramCache, length);
- }
- catch(std::exception const& e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in read_histogram_cache" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in read_histogram_cache");
}
return {};
@@ -143,11 +134,9 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
try {
PYBIND11_OVERLOAD_PURE_NAME(
void, nvinfer1::IInt8LegacyCalibrator, "write_histogram_cache", writeHistogramCache, ptr, length);
- }
- catch(std::exception const& e) {
+ } catch (std::exception const& e) {
LOG_ERROR("Exception caught in write_histogram_cache" + std::string(e.what()));
- }
- catch(...) {
+ } catch (...) {
LOG_ERROR("Exception caught in write_histogram_cache");
}
}
ERROR: Some files do not conform to style guidelines
|
Can you run |
Signed-off-by: Anurag Dixit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anurag Dixit [email protected]
Description
Fixing the failures for pybind related on nightly builds in circleci
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: