Skip to content

Commit 7d70448

Browse files
authored
Merge pull request #29 from pytorch/grad_fix
Fix for changed .grad type
2 parents 0435cb1 + e6aecf5 commit 7d70448

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

word_language_model/main.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def evaluate(model, data, criterion, bsz):
101101
def clipGradient(model, clip):
102102
totalnorm = 0
103103
for p in model.parameters():
104-
modulenorm = p.grad.norm()
104+
modulenorm = p.grad.data.norm()
105105
totalnorm += modulenorm ** 2
106106
totalnorm = math.sqrt(totalnorm)
107107
return min(1, args.clip / (totalnorm + 1e-6))
@@ -140,7 +140,7 @@ def repackageHidden(h):
140140
clipped_lr = lr * clipGradient(model, args.clip)
141141

142142
for p in model.parameters():
143-
p.data.sub_(p.grad.mul(clipped_lr))
143+
p.data.sub_(p.grad.data.mul(clipped_lr))
144144

145145
hidden = repackageHidden(hidden)
146146
model.zero_grad()

0 commit comments

Comments
 (0)