Skip to content

Commit 162a0b9

Browse files
harishs88ssfacebook-github-bot
authored andcommitted
Remove explicit descriptor where not needed (#9046)
Summary: we only need this for constructors with one param Reviewed By: JacobSzwejbka Differential Revision: D70793102
1 parent b8f66f9 commit 162a0b9

File tree

1 file changed

+2
-5
lines changed
  • extension/training/optimizer

1 file changed

+2
-5
lines changed

extension/training/optimizer/sgd.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,17 +179,14 @@ class ET_EXPERIMENTAL SGDParamGroup {
179179
*/
180180
class ET_EXPERIMENTAL SGD {
181181
public:
182-
explicit SGD(
183-
const std::vector<SGDParamGroup>& param_groups,
184-
SGDOptions defaults)
182+
SGD(const std::vector<SGDParamGroup>& param_groups, SGDOptions defaults)
185183
: defaults_(std::make_unique<SGDOptions>(defaults)) {
186184
for (const auto& param_group : param_groups) {
187185
add_param_group(param_group);
188186
}
189187
}
190188

191-
explicit SGD(
192-
const std::map<executorch::aten::string_view, executorch::aten::Tensor>&
189+
SGD(const std::map<executorch::aten::string_view, executorch::aten::Tensor>&
193190
named_parameters,
194191
SGDOptions defaults)
195192
: SGD({SGDParamGroup(named_parameters)}, defaults) {}

0 commit comments

Comments
 (0)