Skip to content

Commit 3eb0193

Browse files
committed
Added info in CONTRIBUTING and new contributor guide on how to merge PRs
1 parent 403bd39 commit 3eb0193

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed
Loading
Loading
Loading

docs/source/new-contributor-guide.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,18 @@ Once you've successfully finished local development, it's time to send out your
279279
280280
![](./_static/img/new-contributor-guide/pr_approval2.png)
281281
282-
Once you've received the required approval from a core contributor, you can go ahead and merge your PR. Congratulations — you're now an official ExecuTorch contributor!
282+
6. Once you've received the required approval from a core contributor, you're very nearly done. We just need to make sure all the CI checks have passed, some of which need approval from a maintainer to start:
283283
284-
Great job making it to the end of our guide — we hope you enjoy contributing. Once again, please check out **[Discord Server](https://discord.com/invite/Dh43CKSAdc)** if you want to say hello, ask any questions, or talk about any and all things ExecuTorch. We look forward to receiving your contributions!
284+
![](./_static/img/new-contributor-guide/how_to_merge1.png)
285+
286+
Once all checks these have all been approved, ran, and passed, you can go ahead and merge your PR. If there's a grey `Update branch` button instead of a green `Merge pull request` button, click that first:
287+
288+
![](./_static/img/new-contributor-guide/how_to_merge2.png)
289+
290+
After a moment, the branch should update with the latest changes, and you'll see the final green `Merge pull request` button:
291+
292+
![](./_static/img/new-contributor-guide/how_to_merge3.png)
293+
294+
Click it to merge your changes into the main codebase. Congratulations — you're now an official ExecuTorch contributor!
295+
296+
Great job making it to the end of our guide — we hope you enjoy contributing. Once again, please check out our **[Discord Server](https://discord.com/invite/Dh43CKSAdc)** if you want to say hello, ask any questions, or talk about any and all things ExecuTorch. We look forward to receiving your contributions!

0 commit comments

Comments
 (0)