Skip to content

Commit f13bc51

Browse files
Arm backend: Convert assert to throw ValueError in op_exp
Asserts are converted to proper raises to ensure graph integrity. It should not be possible for exp to have more than 1 input for a correctly formatted graph, but in the node visitor we cannot know for sure that the graph is formatted correctly. torch.exp supports more data types than fp32, which is why it should be checked. Change-Id: I43ec2aa6bed20c871cd1a0f8d97ab12accc29533 Signed-off-by: Sebastian Larsson <[email protected]>
1 parent 302cb06 commit f13bc51

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

backends/arm/operators/op_exp.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,14 @@ def define_node(
3636
output: TosaArg,
3737
) -> None:
3838

39-
assert len(node.all_input_nodes) == 1
40-
assert inputs[0].dtype == output.dtype == ts.DType.FP32
39+
if len(node.all_input_nodes) != 1:
40+
raise ValueError(
41+
f"Expected 1 input for {self.target}, got {len(node.all_input_nodes)}"
42+
)
43+
if inputs[0].dtype != ts.DType.FP32 or output.dtype != ts.DType.FP32:
44+
raise ValueError(
45+
f"Input and output for {self.target} need to be FP32, got input dtype: "
46+
f"{inputs[0].dtype} and output dtype: {output.dtype}"
47+
)
4148

4249
tosa_graph.addOperator(TosaOp.Op().EXP, [inputs[0].name], [output.name])

0 commit comments

Comments
 (0)