Skip to content

Commit 7d1cc50

Browse files
Refactor py versioning in package tests yaml. (#185)
Summary: We want to be able to pip install multipy runtime via setup.py. To do so, we need to install dependencies and use version numbers in the same way as runtime/nightly tests. This PR includes the py versioning changes to package tests' YAML. Pull Request resolved: #185 Test Plan: No changes to functionality with this PR. Reviewed By: PaliC Differential Revision: D39745163 Pulled By: anirbanr-fb-r2p fbshipit-source-id: 47b7b7eae2566a1e837be46b475f97f3b5524369
1 parent 77da3f4 commit 7d1cc50

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.github/workflows/package_tests.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,23 @@ jobs:
1313
unittest:
1414
strategy:
1515
matrix:
16-
python-version: [3.7, 3.8, 3.9]
16+
python-major-version: [3]
17+
python-minor-version: [7,8,9]
1718
platform: [ubuntu-18.04]
1819
include:
19-
- python-version: 3.9
20+
- python-major-version: 3
21+
python-minor-version: 9
2022
platform: macos-latest
2123
fail-fast: false
2224
runs-on: ${{ matrix.platform }}
2325
steps:
24-
- name: Setup Python ${{ matrix.python-version }}
26+
- name: Set Python Version
27+
run: |
28+
echo "python-version=${{ matrix.python-major-version }}.${{ matrix.python-minor-version }}" >> $GITHUB_ENV
29+
- name: Setup Python ${{ env.python-version }}
2530
uses: actions/setup-python@v2
2631
with:
27-
python-version: ${{ matrix.python-version }}
32+
python-version: ${{ env.python-version }}
2833
architecture: x64
2934
- name: Checkout MultiPy
3035
uses: actions/checkout@v2

setup.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ def get_nightly_version():
7575
# latest numpy doesn't support 3.7
7676
"numpy<=1.21.6",
7777
],
78+
':python_version < "3.12"': [
79+
"setuptools<60.0",
80+
],
7881
},
7982
# PyPI package information.
8083
classifiers=[

0 commit comments

Comments
 (0)