You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Right now, when we `enter` context after `get_fb_runner`, we are using the existing definition in `Runner` which causes type erasure to the super type `Runner`.
While this is fine for most cases, we lose the ability to access the `dryrun` api defined in https://www.internalfb.com/code/fbsource/[587e66c70ce546a78a71b1a22125850d1aff866d]/fbcode/torchx/runner/fb/api.py?lines=103
which has extra parameters.
For orchestration sdk to translate single job definitions as part of its dag correctly, we wish to use FBRunner's implementation of `dryrun`, so we need to be able to access `FBRunner` after entering the context manager.
Here, we add corresponding `enter` and `exit` on the FBRunner to prevent erasing the type.
All implementation still delegates to the existing super functions
Reviewed By: kiukchung
Differential Revision: D72677312
0 commit comments