You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Split out ttfb into its own logging handler and only hook it up to `torchx.runner.events.handler` if the module is included. Also splits out ttfb into its own BUCK target (`//torchx/runner/events/fb:ttfb`)
NOTE: Dependants of //torchx/runner:lib will still get ttfb since I added an manual dep to //torchx/runner/events/fb:ttfb to it. Otherwise users now have to explicitly add a dep to ttfb.
## Motivation
ttfb pulls unwanted deps such as quickflow (see output of `buck cquery "deps(//torchx/runner/events/fb:ttfb)"`). This prevents us from creating `torchx-lite` - a minimal set of torchx APIs (with no scheduler/workspace implementations pulled transitively).
## Other Notes
Removed the unused `//torchx/runner/events:handlers_oss` targets which was confusing autodeps - hence requiring `autodeps-skip` in `//torchx/runner/events:lib`
Differential Revision: D73060221
0 commit comments