Skip to content

Commit a674222

Browse files
zmodemkraj
authored andcommitted
[Backport] Fix base::IDMap::Iterator::operator=
It was referring to non-existing members of Iterator. Presumably this wasn't noticed because the compiler was doing the name lookup at instantiation time and this function was never instantiated, but a recent Clang change [1] uncovered it. 1. llvm/llvm-project#90152 Upstream-Status: Backport [https://chromium-review.googlesource.com/c/chromium/src/+/5512719] Bug: 338536260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512719 Auto-Submit: Hans Wennborg <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1296463} Pick-to: 118-based Change-Id: I2192aab954f58b6b555822dea6801fddcb99f8f0 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/586000 Reviewed-by: Peter Varga <[email protected]>
1 parent 7598794 commit a674222

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

chromium/base/containers/id_map.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,8 @@ class IDMap final {
178178
}
179179

180180
const Iterator& operator=(const Iterator& iter) {
181-
map_ = iter.map;
182-
iter_ = iter.iter;
181+
map_ = iter.map_;
182+
iter_ = iter.iter_;
183183
Init();
184184
return *this;
185185
}

0 commit comments

Comments
 (0)