Skip to content

Commit 4b7bdbb

Browse files
committed
more changes to make docker tests work with go1.16
1 parent ca08729 commit 4b7bdbb

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

_test/install/binary_gopath/expected3.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
/usr/local/go/src/encoding/json/stream.go:456:25: interfaceAddr: taking address of interface-typed value (rules.go:27)
66
/usr/local/go/src/encoding/asn1/marshal_test.go:281:28: interfaceAddr: taking address of interface-typed value (rules.go:27)
77
/usr/local/go/src/encoding/asn1/marshal_test.go:303:28: interfaceAddr: taking address of interface-typed value (rules.go:27)
8-
/usr/local/go/src/encoding/base32/base32_test.go:99:4: exprUnparen: the parentheses around p.encoded[len(p.encoded)-1] == '=' are superfluous (rules.go:21)
9-
/usr/local/go/src/encoding/binary/binary_test.go:447:5: boolComparison: omit bool literal in expression (rules1.go:9)
10-
/usr/local/go/src/encoding/binary/binary_test.go:450:5: boolComparison: omit bool literal in expression (rules1.go:9)
8+
/usr/local/go/src/encoding/base32/base32_test.go:98:4: exprUnparen: the parentheses around p.encoded[len(p.encoded)-1] == '=' are superfluous (rules.go:21)
9+
/usr/local/go/src/encoding/binary/binary_test.go:446:5: boolComparison: omit bool literal in expression (rules1.go:9)
10+
/usr/local/go/src/encoding/binary/binary_test.go:449:5: boolComparison: omit bool literal in expression (rules1.go:9)
1111
/usr/local/go/src/encoding/gob/codec_test.go:351:6: boolComparison: omit bool literal in expression (rules1.go:9)
1212
/usr/local/go/src/encoding/gob/codec_test.go:1402:23: interfaceAddr: taking address of interface-typed value (rules.go:27)
1313
/usr/local/go/src/encoding/gob/codec_test.go:1415:23: interfaceAddr: taking address of interface-typed value (rules.go:27)
@@ -26,8 +26,8 @@
2626
/usr/local/go/src/encoding/json/decode_test.go:2379:24: interfaceAddr: taking address of interface-typed value (rules.go:27)
2727
/usr/local/go/src/encoding/json/decode_test.go:2407:6: interfaceAddr: taking address of interface-typed value (rules.go:27)
2828
/usr/local/go/src/encoding/json/decode_test.go:2526:12: interfaceAddr: taking address of interface-typed value (rules.go:27)
29-
/usr/local/go/src/encoding/json/stream_test.go:189:25: interfaceAddr: taking address of interface-typed value (rules.go:27)
30-
/usr/local/go/src/encoding/json/stream_test.go:305:34: interfaceAddr: taking address of interface-typed value (rules.go:27)
31-
/usr/local/go/src/encoding/json/stream_test.go:419:22: interfaceAddr: taking address of interface-typed value (rules.go:27)
29+
/usr/local/go/src/encoding/json/stream_test.go:188:25: interfaceAddr: taking address of interface-typed value (rules.go:27)
30+
/usr/local/go/src/encoding/json/stream_test.go:304:34: interfaceAddr: taking address of interface-typed value (rules.go:27)
31+
/usr/local/go/src/encoding/json/stream_test.go:418:22: interfaceAddr: taking address of interface-typed value (rules.go:27)
3232
/usr/local/go/src/encoding/json/tagkey_test.go:105:22: interfaceAddr: taking address of interface-typed value (rules.go:27)
3333
/usr/local/go/src/encoding/xml/marshal_test.go:391:9: interfaceAddr: taking address of interface-typed value (rules.go:27)

_test/install/binary_gopath/test.bash

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ release=$1
44

55
apk update && apk add git
66

7+
export GO111MODULE=off
8+
79
cd /root
810

911
wget "https://github.com/quasilyte/go-ruleguard/releases/download/$release/ruleguard-linux-amd64.zip"
1012
unzip ruleguard-linux-amd64.zip
1113

1214
go get -v -u github.com/quasilyte/go-ruleguard/dsl
13-
go get -v -u github.com/quasilyte/ruleguard-rules-test
15+
go get -v -u github.com/quasilyte/ruleguard-rules-test/...
1416

1517
./ruleguard -rules /root/rules.go /root/target.go &> actual.txt || true
1618
diff -u actual.txt /root/expected.txt

_test/install/binary_nogopath/expected3.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
/usr/local/go/src/encoding/json/stream.go:456:25: interfaceAddr: taking address of interface-typed value (rules.go:29)
66
/usr/local/go/src/encoding/asn1/marshal_test.go:281:28: interfaceAddr: taking address of interface-typed value (rules.go:29)
77
/usr/local/go/src/encoding/asn1/marshal_test.go:303:28: interfaceAddr: taking address of interface-typed value (rules.go:29)
8-
/usr/local/go/src/encoding/base32/base32_test.go:99:4: exprUnparen: the parentheses around p.encoded[len(p.encoded)-1] == '=' are superfluous (rules.go:23)
9-
/usr/local/go/src/encoding/binary/binary_test.go:447:5: boolComparison: omit bool literal in expression (rules1.go:9)
10-
/usr/local/go/src/encoding/binary/binary_test.go:450:5: boolComparison: omit bool literal in expression (rules1.go:9)
8+
/usr/local/go/src/encoding/base32/base32_test.go:98:4: exprUnparen: the parentheses around p.encoded[len(p.encoded)-1] == '=' are superfluous (rules.go:23)
9+
/usr/local/go/src/encoding/binary/binary_test.go:446:5: boolComparison: omit bool literal in expression (rules1.go:9)
10+
/usr/local/go/src/encoding/binary/binary_test.go:449:5: boolComparison: omit bool literal in expression (rules1.go:9)
1111
/usr/local/go/src/encoding/gob/codec_test.go:351:6: boolComparison: omit bool literal in expression (rules1.go:9)
1212
/usr/local/go/src/encoding/gob/codec_test.go:1402:23: interfaceAddr: taking address of interface-typed value (rules.go:29)
1313
/usr/local/go/src/encoding/gob/codec_test.go:1415:23: interfaceAddr: taking address of interface-typed value (rules.go:29)
@@ -26,8 +26,8 @@
2626
/usr/local/go/src/encoding/json/decode_test.go:2379:24: interfaceAddr: taking address of interface-typed value (rules.go:29)
2727
/usr/local/go/src/encoding/json/decode_test.go:2407:6: interfaceAddr: taking address of interface-typed value (rules.go:29)
2828
/usr/local/go/src/encoding/json/decode_test.go:2526:12: interfaceAddr: taking address of interface-typed value (rules.go:29)
29-
/usr/local/go/src/encoding/json/stream_test.go:189:25: interfaceAddr: taking address of interface-typed value (rules.go:29)
30-
/usr/local/go/src/encoding/json/stream_test.go:305:34: interfaceAddr: taking address of interface-typed value (rules.go:29)
31-
/usr/local/go/src/encoding/json/stream_test.go:419:22: interfaceAddr: taking address of interface-typed value (rules.go:29)
29+
/usr/local/go/src/encoding/json/stream_test.go:188:25: interfaceAddr: taking address of interface-typed value (rules.go:29)
30+
/usr/local/go/src/encoding/json/stream_test.go:304:34: interfaceAddr: taking address of interface-typed value (rules.go:29)
31+
/usr/local/go/src/encoding/json/stream_test.go:418:22: interfaceAddr: taking address of interface-typed value (rules.go:29)
3232
/usr/local/go/src/encoding/json/tagkey_test.go:105:22: interfaceAddr: taking address of interface-typed value (rules.go:29)
3333
/usr/local/go/src/encoding/xml/marshal_test.go:391:9: interfaceAddr: taking address of interface-typed value (rules.go:29)

_test/install/binary_nogopath/test.bash

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@ unzip ruleguard-linux-amd64.zip
1919
go mod init test
2020
go get -v -u github.com/quasilyte/go-ruleguard/dsl@master
2121
go get -v -u github.com/quasilyte/ruleguard-rules-test@master
22+
go get -v -u github.com/quasilyte/ruleguard-rules-test/sub2@master
2223

2324
./ruleguard -rules rules.go /root/target.go &> actual.txt || true
2425
diff -u actual.txt /root/expected.txt
2526

2627
./ruleguard -e 'm.Match(`$f($*_, ($x), $*_)`)' /root/target.go &> actual.txt || true
2728
diff -u actual.txt /root/expected2.txt
2829

29-
# TODO: make it work with `go mod vendor` properly.
30-
unset GO111MODULE
30+
export GO111MODULE=off
3131
cd /usr/local/go
3232
go get -v -u github.com/quasilyte/go-ruleguard/dsl
33-
go get -v -u github.com/quasilyte/ruleguard-rules-test
33+
go get -v -u github.com/quasilyte/ruleguard-rules-test/...
3434
CGO_ENABLED=0 /root/test/ruleguard -rules /root/rules.go ./src/encoding/... &> actual.txt || true
3535
diff -u actual.txt /root/expected3.txt
3636

0 commit comments

Comments
 (0)