Skip to content

Commit 689bcf9

Browse files
committed
Document MiniKV limitations
1 parent bd570a4 commit 689bcf9

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

quickwit/quickwit-search/src/scroll_context.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ use crate::ClusterClient;
3838

3939
/// Maximum number of values in the local search KV store.
4040
///
41-
/// Currently this store is only used for caching scroll contexts.
42-
///
4341
/// TODO make configurable.
4442
///
4543
/// Assuming a search context of 1MB, this can
@@ -128,6 +126,13 @@ struct TrackedValue {
128126
_total_size_metric_guard: GaugeGuard<'static>,
129127
}
130128

129+
/// In memory key value store with TTL and limited size.
130+
///
131+
/// Once the capacity [LOCAL_KV_CACHE_SIZE] is reached, the oldest entries are
132+
/// removed.
133+
///
134+
/// Currently this store is only used for caching scroll contexts. Using it for
135+
/// other purposes is risky as use cases would compete for its capacity.
131136
#[derive(Clone)]
132137
pub(crate) struct MiniKV {
133138
ttl_with_cache: Arc<RwLock<TtlCache<Vec<u8>, TrackedValue>>>,

0 commit comments

Comments
 (0)