Skip to content

Commit 16170d0

Browse files
Ayanda-Dmichaelklishin
authored andcommitted
Update QQ force-shrink logging
(cherry picked from commit dd5ec3c)
1 parent c9d97e6 commit 16170d0

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

deps/rabbit/src/rabbit_quorum_queue.erl

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1953,9 +1953,10 @@ notify_decorators(QName, F, A) ->
19531953
is_stateful() -> true.
19541954

19551955
force_shrink_member_to_current_member(VHost, Name) ->
1956-
rabbit_log:warning("Disaster recovery procedure: shrinking ~p queue at vhost ~p to a single node cluster", [Name, VHost]),
19571956
Node = node(),
19581957
QName = rabbit_misc:r(VHost, queue, Name),
1958+
QNameFmt = rabbit_misc:rs(QName),
1959+
rabbit_log:warning("Shrinking ~ts to a single node: ~ts", [QNameFmt, Node]),
19591960
case rabbit_amqqueue:lookup(QName) of
19601961
{ok, Q} when ?is_amqqueue(Q) ->
19611962
{RaName, _} = amqqueue:get_pid(Q),
@@ -1968,19 +1969,19 @@ force_shrink_member_to_current_member(VHost, Name) ->
19681969
end,
19691970
_ = rabbit_amqqueue:update(QName, Fun),
19701971
_ = [ra:force_delete_server(?RA_SYSTEM, {RaName, N}) || N <- OtherNodes],
1971-
rabbit_log:warning("Disaster recovery procedure: shrinking finished");
1972+
rabbit_log:warning("Shrinking ~ts finished", [QNameFmt]);
19721973
_ ->
1973-
rabbit_log:warning("Disaster recovery procedure: shrinking failed, queue ~p not found at vhost ~p", [Name, VHost]),
1974+
rabbit_log:warning("Shrinking failed, ~ts not found", [QNameFmt]),
19741975
{error, not_found}
19751976
end.
19761977

19771978
force_vhost_queues_shrink_member_to_current_member(VHost) when is_binary(VHost) ->
1978-
rabbit_log:warning("Disaster recovery procedure: shrinking all quorum queues in vhost ~tp to a single node cluster", [VHost]),
1979+
rabbit_log:warning("Shrinking all quorum queues in vhost '~ts' to a single node: ~ts", [VHost, node()]),
19791980
ListQQs = fun() -> rabbit_amqqueue:list(VHost) end,
19801981
force_all_queues_shrink_member_to_current_member(ListQQs).
19811982

19821983
force_all_queues_shrink_member_to_current_member() ->
1983-
rabbit_log:warning("Disaster recovery procedure: shrinking all quorum queues to a single node cluster"),
1984+
rabbit_log:warning("Shrinking all quorum queues to a single node: ~ts", [node()]),
19841985
ListQQs = fun() -> rabbit_amqqueue:list() end,
19851986
force_all_queues_shrink_member_to_current_member(ListQQs).
19861987

@@ -1990,7 +1991,7 @@ force_all_queues_shrink_member_to_current_member(ListQQFun) when is_function(Lis
19901991
QName = amqqueue:get_name(Q),
19911992
{RaName, _} = amqqueue:get_pid(Q),
19921993
OtherNodes = lists:delete(Node, get_nodes(Q)),
1993-
rabbit_log:warning("Disaster recovery procedure: shrinking queue ~p", [QName]),
1994+
rabbit_log:warning("Shrinking queue ~ts to a single node: ~ts", [rabbit_misc:rs(QName), Node]),
19941995
ok = ra_server_proc:force_shrink_members_to_current_member({RaName, Node}),
19951996
Fun = fun (QQ) ->
19961997
TS0 = amqqueue:get_type_state(QQ),
@@ -2000,7 +2001,7 @@ force_all_queues_shrink_member_to_current_member(ListQQFun) when is_function(Lis
20002001
_ = rabbit_amqqueue:update(QName, Fun),
20012002
_ = [ra:force_delete_server(?RA_SYSTEM, {RaName, N}) || N <- OtherNodes]
20022003
end || Q <- ListQQFun(), amqqueue:get_type(Q) == ?MODULE],
2003-
rabbit_log:warning("Disaster recovery procedure: shrinking finished"),
2004+
rabbit_log:warning("Shrinking finished"),
20042005
ok.
20052006

20062007
is_minority(All, Up) ->

0 commit comments

Comments
 (0)