[WIP] trying to fix

Author: bf4

lib/active_model_serializers/adapter/json_api.rb

@@ -48,7 +48,7 @@ def success_document(options)
 
         if is_collection && serializer.paginated?
           hash[:links] ||= {}
-          hash[:links].update(pagination_links_for(serializer, options))
+          hash[:links].update(pagination_links_for(serializer))
         end
 
         hash
@@ -181,8 +181,8 @@ def links_for(serializer)
       end
 
       # {http://jsonapi.org/format/#fetching-pagination Pagination Links}
-      def pagination_links_for(serializer, options)
-        PaginationLinks.new(serializer.object, options[:serialization_context]).serializable_hash(options)
+      def pagination_links_for(serializer)
+        PaginationLinks.new(serializer.object, instance_options[:serialization_context]).as_json(instance_options)
       end
 
       # {http://jsonapi.org/format/#document-meta Docment Meta}

lib/active_model_serializers/adapter/json_api/pagination_links.rb

@@ -11,7 +11,7 @@ def initialize(collection, context)
           @context = context
         end
 
-        def serializable_hash(options = {})
+        def as_json(options = {})
           pages_from.each_with_object({}) do |(key, value), hash|
             params = query_parameters.merge(page: { number: value, size: collection.size }).to_query
 

test/adapter/json_api/pagination_links_test.rb

@@ -23,12 +23,18 @@ def mock_request(query_parameters = {}, original_url = URI)
           context = Minitest::Mock.new
           context.expect(:request_url, original_url)
           context.expect(:query_parameters, query_parameters)
-          @options = {}
-          @options[:serialization_context] = context
+          @serializer_options = {
+            serialization_context: context,
+            adapter: :json_api
+          }
         end
 
         def load_adapter(paginated_collection, options = {})
-          options = options.merge(adapter: :json_api)
+          if options
+            options.merge!(@serializer_options)
+          else
+            options = @serializer_options
+          end
           ActiveModel::SerializableResource.new(paginated_collection, options)
         end
 
@@ -84,22 +90,22 @@ def test_pagination_links_using_kaminari
           adapter = load_adapter(using_kaminari)
 
           mock_request
-          assert_equal expected_response_with_pagination_links, adapter.serializable_hash(@options)
+          assert_equal expected_response_with_pagination_links, adapter.serializable_hash
         end
 
         def test_pagination_links_using_will_paginate
           adapter = load_adapter(using_will_paginate)
 
           mock_request
-          assert_equal expected_response_with_pagination_links, adapter.serializable_hash(@options)
+          assert_equal expected_response_with_pagination_links, adapter.serializable_hash
         end
 
         def test_pagination_links_with_additional_params
           adapter = load_adapter(using_will_paginate)
 
           mock_request({ test: 'test' })
           assert_equal expected_response_with_pagination_links_and_additional_params,
-            adapter.serializable_hash(@options)
+            adapter.serializable_hash
         end
 
         def test_not_showing_pagination_links