Skip to content

Commit d8b2b94

Browse files
committed
Merge pull request #1387 from bf4/add_rubocop_todos_to_contributing
Add rubocop todos to contributing [ci skip]
2 parents 63ed552 + f8b3af8 commit d8b2b94

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ http://www.commitstrip.com/en/2014/05/07/the-truth-behind-open-source-apps/](doc
99
## How can I help?
1010

1111
- [Filing an issue](CONTRIBUTING.md#filing-an-issue)
12-
- [Writing code and comments](CONTRIBUTING#writing-code-and-comments)
12+
- [Writing code and comments](CONTRIBUTING.md#writing-code-and-comments)
1313

1414
### Filing an issue
1515

@@ -100,6 +100,10 @@ And please don't forget to stay involved in the issue until it is closed! Thanks
100100

101101
- [Improve amount of code exercised by tests](https://codeclimate.com/github/rails-api/active_model_serializers/coverage?sort=covered_percent&sort_direction=asc).
102102

103+
- [Fix RuboCop (Style) TODOS](https://github.com/rails-api/active_model_serializers/blob/master/.rubocop_todo.yml).
104+
- Delete and offsense, run `rake rubocop` (or possibly `rake rubocop:auto_correct`),
105+
and [submit a PR](CONTRIBUTING.md#submitting-a-pull-request-pr).
106+
103107
- We are also encouraging comments to substantial changes (larger than bugfixes and simple features) under an
104108
"RFC" (Request for Comments) process before we start active development.
105109
Look for the [**RFC**](https://github.com/rails-api/active_model_serializers/labels/RFC) label.
@@ -118,7 +122,7 @@ To fetch & test the library for development, do:
118122
1. `git clone https://github.com/{whoami}/active_model_serializers.git`
119123
1. `cd active_model_serializers`
120124
1. `bundle`
121-
- To test against a particular rails version, 4.0 is usually the most buggy, set then
125+
- To test against a particular rails version-- 4.0 is usually the most buggy-- set then
122126
RAILS_VERSION environment variable as described in the [.travis.yml](.travis.yml).
123127
e.g. `export RAILS_VERSION=4.0`.
124128
1. Create your PR branch (`git checkout -b my-helpful-pr`)
@@ -137,7 +141,7 @@ To fetch & test the library for development, do:
137141
- Extra Credit: [Confirm it runs and tests pass on the rubies specified in the travis
138142
config](.travis.yml). A maintainer will otherwise confirm it runs on these.
139143

140-
1. *Bonus Points** Update [CHANGELOG.md](https://github.com/rails-api/active_model_serializers/blob/master/CHANGELOG.md)
144+
1. *Bonus Points* Update [CHANGELOG.md](https://github.com/rails-api/active_model_serializers/blob/master/CHANGELOG.md)
141145
with a brief description of any breaking changes, fixes, features, or
142146
miscellaneous changes under the proper version section.
143147
1. Iterate on feedback given by the community (fix syntax, modify bits of code, add

0 commit comments

Comments
 (0)