Make Controller#get_serializer(resource, options) the main interface

See
https://groups.google.com/d/topic/rubyonrails-core/K8t4-DZ_DkQ/discussion

RFC: Rails-API: Proposed better interface for registering serializers
with the controller

Summary:

I propose there be a first-class serializer interface in Rails much like
there is for renderers.
Proposed interfaces are: `serializer_for` and `ActionController::Serializers.register`

Author: bf4

lib/action_controller/serialization.rb

@@ -19,29 +19,31 @@ def serialization_scope
         respond_to?(_serialization_scope, true)
     end
 
-    # Deprecated
-    def get_serializer(resource)
-      fail ActiveModel::Serializer::Error, "ActionController::Serialization##{__method__} has been removed. "\
-        "Please use ActiveSupport::Serializer.build instead"
+    def get_serializer(resource, options = {})
+      if ! use_adapter?
+        warn "ActionController::Serialization##{__method__} has been removed. "\
+          "Please pass 'adapter: false'  or see ActiveSupport::Serializer.build"
+        options[:adapter] = false
+      end
+      serializable_resource = ActiveModel::Serializer::build(resource, options) do |builder|
+        if builder.serializer?
+          builder.serialization_scope ||= serialization_scope
+          builder.serialization_scope_name = _serialization_scope
+          builder.adapter
+        else
+          resource
+        end
+      end
     end
 
     # Deprecated
     def use_adapter?
-      fail ActiveModel::Serializer::Error, "ActionController::Serialization##{__method__} has been removed. "\
-        "Please use ActiveSupport::Serializer.build instead"
+      true
     end
 
     [:_render_option_json, :_render_with_renderer_json].each do |renderer_method|
       define_method renderer_method do |resource, options|
-        serializable_resource = ActiveModel::Serializer::build(resource, options) do |builder|
-          if builder.serializer?
-            builder.serialization_scope ||= serialization_scope
-            builder.serialization_scope_name = _serialization_scope
-            builder.adapter
-          else
-            resource
-          end
-        end
+        serializable_resource = get_serializer(resource, options)
         super(serializable_resource, options)
       end
     end

lib/active_model/serializer.rb

@@ -2,7 +2,6 @@
 
 module ActiveModel
   class Serializer
-    Error = Class.new(StandardError)
     extend ActiveSupport::Autoload
     autoload :Configuration
     autoload :ArraySerializer

test/action_controller/serialization_test.rb

@@ -327,20 +327,6 @@ def test_cache_expiration_on_update
         assert_equal 'application/json', @response.content_type
         assert_equal expected.to_json, @response.body
       end
-
-      def test_fail_calling_use_adapter_on_controller_instance
-        controller = ImplicitSerializationTestController.new
-        assert_raises(ActiveModel::Serializer::Error) {
-          controller.use_adapter?
-        }
-      end
-
-      def test_fail_calling_get_serializer__on_controller_instance
-        controller = ImplicitSerializationTestController.new
-        assert_raises(ActiveModel::Serializer::Error) {
-          controller.get_serializer(Class.new)
-        }
-      end
     end
   end
 end