You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some bugs are expressly not good for new contributors, so don't expect 100% overlap between the two.
86
87
-[Changelog
87
88
Missing](https://github.com/rails-api/active_model_serializers/issues?q=label%3A%22Changelog+Missing%22+is%3Aclosed) is
88
89
an easy way to help out.
89
90
90
-
- If you want to work on new feature development, look for the label [**Feature**](https://github.com/rails-api/active_model_serializers/labels/Feature).
91
+
-[Fix a bug](https://github.com/rails-api/active_model_serializers/labels/Ready%20for%20PR).
92
+
- Ready for PR - A well defined bug, needs someone to PR a fix.
93
+
- Bug - Anything that is broken.
94
+
- Regression - A bug that did not exist in previous versions and isn't a new feature (applied in tandem with Bug).
95
+
- Performance - A performance related issue. We could track this as a bug, but usually these would have slightly lower priority than standard bugs.
96
+
97
+
-[Develop new features](https://github.com/rails-api/active_model_serializers/labels/Feature).
-[Improve amount of code exercised by tests](https://codeclimate.com/github/rails-api/active_model_serializers/coverage?sort=covered_percent&sort_direction=asc).
91
102
92
103
- We are also encouraging comments to substantial changes (larger than bugfixes and simple features) under an
93
104
"RFC" (Request for Comments) process before we start active development.
94
105
Look for the [**RFC**](https://github.com/rails-api/active_model_serializers/labels/RFC) label.
95
106
96
-
## Issue Labeling
97
-
98
-
ActiveModelSerializers uses a subset of [StandardIssueLabels](https://github.com/wagenet/StandardIssueLabels) for Github Issues. You can [see our labels here](https://github.com/rails-api/active_model_serializers/labels).
99
-
100
-
## Submitting a pull request (PR)
107
+
#### Submitting a pull request (PR)
101
108
102
109
1. The vast majority of development is happening under the `master` branch.
103
110
This is where we would suggest you start.
@@ -147,23 +154,48 @@ Remember to [squash your commits](CONTRIBUTING.md#about-pull-requests-prs) and r
147
154
- by force pushing to it
148
155
- A maintainer can make any changes themselves and manually merge the code in.
149
156
150
-
### Commit Messages
157
+
####Commit Messages
151
158
152
159
-[A Note About Git Commit Messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
-[Level up your Git](http://rakeroutes.com/blog/deliberate-git/)
162
169
-[All Your Open Source Code Are Belong To Us](http://www.benjaminfleischer.com/2013/07/30/all-your-open-source-code-are-belong-to-us/)
163
170
164
-
### Running tests
171
+
## Issue Labeling
172
+
173
+
ActiveModelSerializers uses a subset of [StandardIssueLabels](https://github.com/wagenet/StandardIssueLabels) for Github Issues. You can [see our labels here](https://github.com/rails-api/active_model_serializers/labels).
165
174
166
-
#### Running with Rake
175
+
## Running tests
176
+
177
+
Run tests against different Rails versions by setting the RAILS_VERSION variable
178
+
and bundling gems. To test against all versions, you can do something like:
0 commit comments