Skip to content

Commit 1d93e41

Browse files
authored
Merge pull request #246 from vietqhoang/handle-string-response-for-find-latest-version
Handle String response for "find latest version"
2 parents 61054a1 + 38fb116 commit 1d93e41

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

lib/importmap/npm.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def get_json(uri)
8686
end
8787

8888
def find_latest_version(response)
89-
latest_version = response.dig('dist-tags', 'latest')
89+
latest_version = response.is_a?(String) ? response : response.dig('dist-tags', 'latest')
9090
return latest_version if latest_version
9191

9292
return unless response['versions']

test/npm_test.rb

+10
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,14 @@ def code() "200" end
9494
end
9595
end
9696
end
97+
98+
test "return latest version response is a String type" do
99+
response = "version not found".to_json
100+
101+
@npm.stub(:get_json, response) do
102+
outdated_packages = @npm.outdated_packages
103+
104+
assert_equal('version not found', outdated_packages[0].latest_version)
105+
end
106+
end
97107
end

0 commit comments

Comments
 (0)