Skip to content

Commit d0adeae

Browse files
committed
Support new recurring task features
See rails/solid_queue#338
1 parent 7f71ec8 commit d0adeae

File tree

6 files changed

+43
-15
lines changed

6 files changed

+43
-15
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ GEM
117117
erubi (1.12.0)
118118
et-orbi (1.2.11)
119119
tzinfo
120-
fugit (1.11.0)
120+
fugit (1.11.1)
121121
et-orbi (~> 1, >= 1.2.11)
122122
raabro (~> 1.4)
123123
globalid (1.2.1)

app/models/mission_control/jobs/recurring_task.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
class MissionControl::Jobs::RecurringTask
22
include ActiveModel::Model
33

4-
attr_accessor :id, :job_class_name, :arguments, :schedule, :last_enqueued_at
4+
attr_accessor :id, :job_class_name, :command, :arguments, :schedule, :last_enqueued_at, :queue_name, :priority
55

66
def initialize(queue_adapter: ActiveJob::Base.queue_adapter, **kwargs)
77
@queue_adapter = queue_adapter
Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,37 @@
11
<table class="table">
22
<tbody>
3-
<tr>
4-
<th>Job class</th>
5-
<td><%= recurring_task.job_class_name %></td>
6-
</tr>
7-
<tr>
8-
<th>Arguments</th>
9-
<td><div class="is-family-monospace"><%= recurring_task.arguments.join(",") %></div></td>
10-
</tr>
3+
<% if recurring_task.job_class_name.present? %>
4+
<tr>
5+
<th>Job class</th>
6+
<td><%= recurring_task.job_class_name %></td>
7+
</tr>
8+
9+
<tr>
10+
<th>Arguments</th>
11+
<td><div class="is-family-monospace"><%= recurring_task.arguments.join(",") %></div></td>
12+
</tr>
13+
<% elsif recurring_task.command.present? %>
14+
<tr>
15+
<th>Command</th>
16+
<td><div class="is-family-monospace"><%= recurring_task.command %></div></td>
17+
</tr>
18+
<% end %>
19+
1120
<tr>
1221
<th>Schedule</th>
1322
<td><%= recurring_task.schedule %></td>
1423
</tr>
24+
<% if recurring_task.queue_name.present? %>
25+
<tr>
26+
<th>Queue</th>
27+
<td><%= recurring_task.queue_name %></td>
28+
</tr>
29+
<% end %>
30+
<% if recurring_task.priority.present? %>
31+
<tr>
32+
<th>Priority</th>
33+
<td><%= recurring_task.priority %></td>
34+
</tr>
35+
<% end %>
1536
</tbody>
1637
</table>

app/views/mission_control/jobs/recurring_tasks/_recurring_task.html.erb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33
<%= link_to recurring_task.id, application_recurring_task_path(@application, recurring_task.id) %>
44
</td>
55
<td>
6-
<%= link_to recurring_task.job_class_name, application_recurring_task_path(@application, recurring_task.id) %>
6+
<% if recurring_task.job_class_name.present? %>
7+
<%= recurring_task.job_class_name %>
78

8-
<% if recurring_task.arguments.present? %>
9-
<div class="is-family-monospace"><%= recurring_task.arguments.join(",") %></div>
9+
<% if recurring_task.arguments.present? %>
10+
<div class="is-family-monospace"><%= recurring_task.arguments.join(",") %></div>
11+
<% end %>
12+
<% elsif recurring_task.command.present? %>
13+
<div class="is-family-monospace"><%= recurring_task.command %></div>
1014
<% end %>
1115
</td>
1216
<td> <%= recurring_task.schedule %> </td>

lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,11 @@ def recurring_task_attributes_from_solid_queue_recurring_task(task)
2525
{
2626
id: task.key,
2727
job_class_name: task.class_name,
28+
command: task.command,
2829
arguments: task.arguments,
29-
schedule: task.schedule
30+
schedule: task.schedule,
31+
queue_name: task.queue_name,
32+
priority: task.priority
3033
}
3134
end
3235

mission_control-jobs.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
2424
spec.add_dependency "irb", "~> 1.13"
2525

2626
spec.add_development_dependency "resque"
27-
spec.add_development_dependency "solid_queue", ">= 0.5"
27+
spec.add_development_dependency "solid_queue", ">= 0.9"
2828
spec.add_development_dependency "selenium-webdriver"
2929
spec.add_development_dependency "resque-pause"
3030
spec.add_development_dependency "mocha"

0 commit comments

Comments
 (0)