Store full recurring task configuration in process metadata

It'll be handy in Mission Control when we want to show the configured
tasks because we need to aggregate them across dispatchers that might
have different configurations.

Author: rosa

lib/solid_queue/dispatcher.rb

@@ -52,7 +52,7 @@ def unload_recurring_schedule
       end
 
       def metadata
-        super.merge(batch_size: batch_size, concurrency_maintenance_interval: concurrency_maintenance&.interval, recurring_schedule: recurring_schedule.tasks.presence)
+        super.merge(batch_size: batch_size, concurrency_maintenance_interval: concurrency_maintenance&.interval, recurring_schedule: recurring_schedule.tasks.presence )
       end
   end
 end

lib/solid_queue/dispatcher/recurring_schedule.rb

@@ -27,11 +27,11 @@ def unload_tasks
     end
 
     def tasks
-      configured_tasks.map(&:to_s)
+      configured_tasks.each_with_object({}) { |task, hsh| hsh[task.key] = task.to_h }
     end
 
     def inspect
-      tasks.map(&:to_s).join(" | ")
+      configured_tasks.map(&:to_s).join(" | ")
     end
 
     private

lib/solid_queue/dispatcher/recurring_task.rb

@@ -17,7 +17,7 @@ def from_configuration(key, **options)
     def initialize(key, class_name:, schedule:, arguments: nil)
       @key = key
       @class_name = class_name
-      @schedule = Fugit.parse(schedule)
+      @schedule = schedule
       @arguments = Array(arguments)
     end
 
@@ -26,7 +26,7 @@ def delay_from_now
     end
 
     def next_time
-      schedule.next_time.utc
+      parsed_schedule.next_time.utc
     end
 
     def enqueue(at:)
@@ -38,15 +38,19 @@ def enqueue(at:)
     end
 
     def valid?
-      schedule.instance_of?(Fugit::Cron)
+      parsed_schedule.instance_of?(Fugit::Cron)
     end
 
     def to_s
-      "#{class_name}.perform_later(#{arguments.map(&:inspect).join(",")}) [ #{parsed_schedule} ]"
+      "#{class_name}.perform_later(#{arguments.map(&:inspect).join(",")}) [ #{parsed_schedule.original.to_s} ]"
     end
 
-    def parsed_schedule
-      schedule.original.to_s
+    def to_h
+      {
+        schedule: schedule,
+        class_name: class_name,
+        arguments: arguments
+      }
     end
 
     private
@@ -70,6 +74,10 @@ def arguments_with_kwargs
         end
       end
 
+      def parsed_schedule
+        @parsed_schedule ||= Fugit.parse(schedule)
+      end
+
       def job_class
         @job_class ||= class_name.safe_constantize
       end

test/unit/dispatcher_test.rb

@@ -35,6 +35,7 @@ class DispatcherTest < ActiveSupport::TestCase
     assert_equal "Dispatcher", process.kind
     assert_equal({ "polling_interval" => 0.1, "batch_size" => 10 }, process.metadata)
 
+  ensure
     no_concurrency_maintenance_dispatcher.stop
   end
 
@@ -48,8 +49,11 @@ class DispatcherTest < ActiveSupport::TestCase
 
     process = SolidQueue::Process.first
     assert_equal "Dispatcher", process.kind
-    assert_equal [ "AddToBufferJob.perform_later(42) [ 0 * * * * ]" ], process.metadata["recurring_schedule"]
 
+    schedule_from_metadata = process.metadata["recurring_schedule"]
+    assert_equal 1, schedule_from_metadata.size
+    assert_equal({ "class_name" => "AddToBufferJob", "schedule" => "every hour", "arguments" => [ 42 ] }, schedule_from_metadata["example_task"])
+  ensure
     with_recurring_schedule.stop
   end
 
@@ -97,6 +101,7 @@ class DispatcherTest < ActiveSupport::TestCase
     assert_equal 0, SolidQueue::ScheduledExecution.count
     assert_equal 15, SolidQueue::ReadyExecution.count
 
+  ensure
     another_dispatcher.stop
   end