Skip to content

Commit 6ec2f02

Browse files
author
Clifford Fajardo
committed
attempt at adding name prop to select element
1 parent 08757c1 commit 6ec2f02

File tree

3 files changed

+20
-51
lines changed

3 files changed

+20
-51
lines changed

docs/examples/auto-adjust-dropdown.tsx

Lines changed: 16 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class Test extends React.Component {
88
value: '3',
99
};
1010

11-
onChange = e => {
11+
onChange = (e) => {
1212
let value;
1313
if (e && e.target) {
1414
({ value } = e.target);
@@ -35,48 +35,29 @@ class Test extends React.Component {
3535
<div style={{ display: 'flex', justifyContent: 'space-between' }}>
3636
<div>
3737
<Select
38+
name="test-name-value--------"
3839
onChange={this.onChange}
3940
dropdownMatchSelectWidth={500}
4041
value={value}
4142
>
42-
<Option value="1">
43-
Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack
44-
</Option>
45-
<Option value="2">
46-
Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy
47-
</Option>
43+
<Option value="1">Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack</Option>
44+
<Option value="2">Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy</Option>
4845
<Option value="3">Jill</Option>
4946
</Select>
5047
</div>
5148
<div>
52-
<Select
53-
onChange={this.onChange}
54-
dropdownMatchSelectWidth={500}
55-
value={value}
56-
>
57-
<Option value="1">
58-
Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack
59-
</Option>
60-
<Option value="2">
61-
Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy
62-
</Option>{' '}
49+
<Select onChange={this.onChange} dropdownMatchSelectWidth={500} value={value}>
50+
<Option value="1">Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack</Option>
51+
<Option value="2">Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy</Option>{' '}
6352
<Option value="3">Jill</Option>
6453
</Select>
6554
</div>
6655
</div>
6756
<div style={{ display: 'flex', justifyContent: 'center' }}>
6857
<div>
69-
<Select
70-
onChange={this.onChange}
71-
dropdownMatchSelectWidth={500}
72-
value={value}
73-
>
74-
<Option value="1">
75-
Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack
76-
</Option>
77-
<Option value="2">
78-
Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy
79-
</Option>
58+
<Select onChange={this.onChange} dropdownMatchSelectWidth={500} value={value}>
59+
<Option value="1">Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack</Option>
60+
<Option value="2">Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy</Option>
8061
<Option value="3">Jill</Option>
8162
</Select>
8263
</div>
@@ -88,32 +69,16 @@ class Test extends React.Component {
8869
}}
8970
>
9071
<div>
91-
<Select
92-
onChange={this.onChange}
93-
dropdownMatchSelectWidth={500}
94-
value={value}
95-
>
96-
<Option value="1">
97-
Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack
98-
</Option>
99-
<Option value="2">
100-
Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy
101-
</Option>
72+
<Select onChange={this.onChange} dropdownMatchSelectWidth={500} value={value}>
73+
<Option value="1">Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack</Option>
74+
<Option value="2">Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy</Option>
10275
<Option value="3">Jill</Option>
10376
</Select>
10477
</div>
10578
<div>
106-
<Select
107-
onChange={this.onChange}
108-
dropdownMatchSelectWidth={500}
109-
value={value}
110-
>
111-
<Option value="1">
112-
Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack
113-
</Option>
114-
<Option value="2">
115-
Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy
116-
</Option>
79+
<Select onChange={this.onChange} dropdownMatchSelectWidth={500} value={value}>
80+
<Option value="1">Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack Jack</Option>
81+
<Option value="2">Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy Lucy</Option>
11782
<Option value="3">Jill</Option>
11883
</Select>
11984
</div>

src/BaseSelect.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ export type BaseSelectPropsWithoutPrivate = Omit<BaseSelectProps, keyof BaseSele
121121

122122
export interface BaseSelectProps extends BaseSelectPrivateProps, React.AriaAttributes {
123123
className?: string;
124+
name?: string;
124125
style?: React.CSSProperties;
125126
showSearch?: boolean;
126127
tagRender?: (props: CustomTagProps) => React.ReactElement;
@@ -726,6 +727,7 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
726727
const selectorNode = (
727728
<SelectTrigger
728729
ref={triggerRef}
730+
name={name}
729731
disabled={disabled}
730732
prefixCls={prefixCls}
731733
visible={triggerOpen}

src/Select.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ const Select = React.forwardRef(
159159
const {
160160
id,
161161
mode,
162+
name,
162163
prefixCls = 'rc-select',
163164
backfill,
164165
fieldNames,
@@ -612,6 +613,7 @@ const Select = React.forwardRef(
612613
{...restProps}
613614
// >>> MISC
614615
id={mergedId}
616+
name={name}
615617
prefixCls={prefixCls}
616618
ref={ref}
617619
omitDomProps={OMIT_DOM_PROPS}

0 commit comments

Comments
 (0)