Skip to content

Commit 62794a6

Browse files
jeongshinvonovak
andauthored
fix(ios): allow building with use_frameworks static (#771)
* fix: fix ios build with use_frameworks static * Create gorgeous-countries-exist.md * chore: update podspec * chore: add workflow_dispatch on ci * fix: fix header import * chore: revert workflow_dispatch * Update packages/document-picker/react-native-document-picker.podspec --------- Co-authored-by: Vojtech Novak <[email protected]>
1 parent cd25c26 commit 62794a6

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@react-native-documents/picker": patch
3+
---
4+
5+
fix: enable ios build with use_frameworks static

packages/document-picker/ios/RNDocumentPicker.mm

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@
66
#import "RCTConvert+RNDocumentPicker.h"
77
// this header file is generated by Xcode: https://developer.apple.com/documentation/swift/importing-swift-into-objective-c
88
// if it cannot be found, try cleaning the build folder and Xcode derived data folder
9+
10+
// When using use_frameworks! :linkage => :static in Podfile
11+
#if __has_include(<react_native_document_picker/react_native_document_picker-Swift.h>)
12+
#import <react_native_document_picker/react_native_document_picker-Swift.h>
13+
#else
914
#import "react_native_document_picker-Swift.h"
15+
#endif
16+
1017
// for UIModalPresentationStyle conversion
1118
// remove after https://github.com/facebook/react-native/commit/2d547a3252b328251e49dabfeec85f8d46c85411 is released
1219
#import <React/RCTModalHostViewManager.h>

packages/document-picker/react-native-document-picker.podspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Pod::Spec.new do |s|
2222
}
2323

2424
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
25-
# RN 71+
2625
install_modules_dependencies(s)
2726
else
2827
s.dependency "React-Core"

packages/example/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ PODS:
12101210
- React-jsiexecutor
12111211
- React-RCTFBReactNativeSpec
12121212
- ReactCommon/turbomodule/core
1213-
- react-native-document-picker (10.0.1):
1213+
- react-native-document-picker (10.1.0):
12141214
- DoubleConversion
12151215
- glog
12161216
- hermes-engine
@@ -1885,7 +1885,7 @@ SPEC CHECKSUMS:
18851885
React-logger: 02e5802824aa9b15cb7df42e10a91abead83cd8d
18861886
React-Mapbuffer: 99bd566147aaa78e872568be53ebca8a4449ddae
18871887
React-microtasksnativemodule: 51e7813abf875408a0f367e473a65bbab6aa8481
1888-
react-native-document-picker: 00f3dedbea5b81e9e5d810720d0ed9ff40e3f687
1888+
react-native-document-picker: d566165412d4913ff83e611c6ba51cebaa05cd79
18891889
react-native-document-viewer: e72376e1efe598380803ef661c33e3b3a3c0e3b0
18901890
react-native-segmented-control: bf6e0032726727498e18dd437ae88afcdbc18e99
18911891
react-native-uitextview: d30631440c99dde5210691267bdaf5480a080ffe

0 commit comments

Comments
 (0)