Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Commit 36845f5

Browse files
committed
Hollow out the old tests and fill in something basic.
1 parent a2ec57b commit 36845f5

File tree

5 files changed

+39
-505
lines changed

5 files changed

+39
-505
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"eslint-config-rackt": "^1.1.1",
4848
"eslint-plugin-react": "^3.15.0",
4949
"expect": "^1.13.0",
50-
"history": "^1.14.0",
5150
"isparta": "^4.0.0",
5251
"isparta-loader": "^2.0.0",
5352
"karma": "^0.13.3",
@@ -62,6 +61,7 @@
6261
"karma-webpack": "^1.7.0",
6362
"mocha": "^2.3.4",
6463
"react": "^0.14.3",
64+
"react-router": "^2.0.0-rc5",
6565
"redux": "^3.0.4",
6666
"redux-devtools": "^3.0.0",
6767
"redux-devtools-dock-monitor": "^1.0.1",

src/sync.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export default function syncHistoryWithStore(history, store, {
118118
},
119119

120120
// It also provides a way to destroy internal listeners
121-
dispose() {
121+
unsubscribe() {
122122
if (adjustUrlOnReplay) {
123123
unsubscribeFromStore()
124124
}

test/browser/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { createHashHistory, createHistory } from 'history'
1+
import { hashHistory, browserHistory } from 'react-router'
22
import createTests from '../createTests.js'
33

4-
createTests(createHashHistory, 'Hash History', () => window.location = '#/')
5-
createTests(createHistory, 'Browser History', () => window.history.replaceState(null, null, '/'))
4+
createTests(hashHistory, 'Hash History', () => window.location = '#/')
5+
createTests(browserHistory, 'Browser History', () => window.history.replaceState(null, null, '/'))

0 commit comments

Comments
 (0)