Skip to content

Commit b53ebb2

Browse files
Merge pull request #788 from Starefossen/enable-docker-testing
Make it possible to test node_redis in a Docker environment
2 parents e34debd + b1ae21d commit b53ebb2

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

test/test.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*global require console setTimeout process Buffer */
2-
var PORT = 6379;
3-
var HOST = '127.0.0.1';
2+
var PORT = process.env.REDIS_PORT_6379_TCP_PORT || 6379;
3+
var HOST = process.env.REDIS_PORT_6379_TCP_ADDR || '127.0.0.1';
44
var parser = process.argv[3];
55

66
var redis = require("../index"),
@@ -116,7 +116,8 @@ next = function next(name) {
116116
// Tests are run in the order they are defined, so FLUSHDB should always be first.
117117

118118
tests.IPV4 = function () {
119-
var ipv4Client = redis.createClient( PORT, "127.0.0.1", { family : "IPv4", parser: parser } );
119+
var ipv4addr = process.env.REDIS_PORT_6379_TCP_ADDR || "127.0.0.1";
120+
var ipv4Client = redis.createClient( PORT, ipv4addr, { family : "IPv4", parser: parser } );
120121

121122
ipv4Client.once("ready", function start_tests() {
122123
console.log("Connected to " + ipv4Client.address + ", Redis server version " + ipv4Client.server_info.redis_version + "\n");
@@ -142,7 +143,8 @@ tests.IPV6 = function () {
142143
console.log("Skipping IPV6 for old Redis server version < 2.8.0");
143144
return run_next_test();
144145
}
145-
var ipv6Client = redis.createClient( PORT, "::1", { family: "IPv6", parser: parser } );
146+
var ipv6addr = process.env.REDIS_PORT_6379_TCP_ADDR || "::1";
147+
var ipv6Client = redis.createClient( PORT, ipv6addr, { family: "IPv6", parser: parser } );
146148

147149
ipv6Client.once("ready", function start_tests() {
148150
console.log("Connected to " + ipv6Client.address + ", Redis server version " + ipv6Client.server_info.redis_version + "\n");
@@ -728,7 +730,7 @@ tests.WATCH_TRANSACTION = function () {
728730

729731

730732
tests.detect_buffers = function () {
731-
var name = "detect_buffers", detect_client = redis.createClient({ detect_buffers: true, parser: parser });
733+
var name = "detect_buffers", detect_client = redis.createClient(PORT, HOST, { detect_buffers: true, parser: parser });
732734

733735
detect_client.on("ready", function () {
734736
// single Buffer or String
@@ -793,7 +795,7 @@ tests.detect_buffers = function () {
793795
};
794796

795797
tests.detect_buffers_multi = function () {
796-
var name = "detect_buffers_multi", detect_client = redis.createClient({detect_buffers: true});
798+
var name = "detect_buffers_multi", detect_client = redis.createClient(PORT, HOST, {detect_buffers: true});
797799

798800
detect_client.on("ready", function () {
799801
// single Buffer or String
@@ -884,9 +886,9 @@ tests.detect_buffers_multi = function () {
884886
tests.socket_nodelay = function () {
885887
var name = "socket_nodelay", c1, c2, c3, ready_count = 0, quit_count = 0;
886888

887-
c1 = redis.createClient({ socket_nodelay: true, parser: parser });
888-
c2 = redis.createClient({ socket_nodelay: false, parser: parser });
889-
c3 = redis.createClient({ parser: parser });
889+
c1 = redis.createClient(PORT, HOST, { socket_nodelay: true, parser: parser });
890+
c2 = redis.createClient(PORT, HOST, { socket_nodelay: false, parser: parser });
891+
c3 = redis.createClient(PORT, HOST, { parser: parser });
890892

891893
function quit_check() {
892894
quit_count++;
@@ -1247,8 +1249,8 @@ tests.SUBSCRIBE_QUIT = function () {
12471249

12481250
tests.SUBSCRIBE_CLOSE_RESUBSCRIBE = function () {
12491251
var name = "SUBSCRIBE_CLOSE_RESUBSCRIBE";
1250-
var c1 = redis.createClient({ parser: parser });
1251-
var c2 = redis.createClient({ parser: parser });
1252+
var c1 = redis.createClient(PORT, HOST, { parser: parser });
1253+
var c2 = redis.createClient(PORT, HOST, { parser: parser });
12521254
var count = 0;
12531255

12541256
/* Create two clients. c1 subscribes to two channels, c2 will publish to them.
@@ -2044,7 +2046,7 @@ tests.MONITOR = function () {
20442046
return next(name);
20452047
}
20462048

2047-
monitor_client = redis.createClient({ parser: parser });
2049+
monitor_client = redis.createClient(PORT, HOST, { parser: parser });
20482050
monitor_client.monitor(function (err, res) {
20492051
client.mget("some", "keys", "foo", "bar");
20502052
client.set("json", JSON.stringify({
@@ -2318,7 +2320,7 @@ tests.reconnectRetryMaxDelay = function() {
23182320

23192321
tests.unref = function () {
23202322
var name = "unref";
2321-
var external = fork("./test/test-unref.js");
2323+
var external = fork("./test/test-unref.js", [PORT, HOST]);
23222324
var done = false;
23232325
external.on("close", function (code) {
23242326
assert(code == 0, "test-unref.js failed");

0 commit comments

Comments
 (0)