Skip to content

Commit 78a5f92

Browse files
committed
Skip testing resp3 parsing for async/py3.7
1 parent 6f8b44a commit 78a5f92

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

tests/test_asyncio/test_connect.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import logging
33
import socket
44
import ssl
5+
import sys
56
from unittest.mock import patch
67

78
import pytest
@@ -19,6 +20,7 @@
1920

2021

2122
_CLIENT_NAME = "test-suite-client"
23+
PY37 = sys.version_info[:2] == (3, 7)
2224

2325

2426
@pytest.fixture
@@ -77,14 +79,15 @@ async def test_tcp_ssl_connect(tcp_address):
7779
(6, 3, True, True),
7880
],
7981
)
80-
# @pytest.mark.parametrize("use_protocol", [2, 3])
81-
# @pytest.mark.parametrize("use_auth", [False, True])
8282
async def test_tcp_auth(
8383
tcp_address, use_protocol, use_auth, use_server_ver, use_client_name
8484
):
8585
"""
8686
Test that various initial handshake cases are handled correctly by the client
8787
"""
88+
if use_protocol == 3 and PY37:
89+
pytest.skip("Python 3.7 does not support protocol 3 for asyncio")
90+
8891
got_auth = []
8992
got_protocol = None
9093
got_name = None

tests/test_connect.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ def test_tcp_ssl_connect(tcp_address):
7575
(6, 3, True, True),
7676
],
7777
)
78-
# @pytest.mark.parametrize("use_protocol", [2, 3])
79-
# @pytest.mark.parametrize("use_auth", [False, True])
8078
def test_tcp_auth(tcp_address, use_protocol, use_auth, use_server_ver, use_client_name):
8179
"""
8280
Test that various initial handshake cases are handled correctly by the client

0 commit comments

Comments
 (0)