Skip to content

fix inconsistent json.get behavior #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix inconsistent json.get behavior #2962

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2023 •
edited by ghost
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Closes #2931

@ghost ghost changed the title fix inconsistent json.get behavior #2931 fix inconsistent json.get behavior Sep 25, 2023
@chayim chayim added the bug Bug label Oct 5, 2023
@chayim chayim requested a review from dvora-h October 5, 2023 07:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d3a3ada) 91.34% compared to head (a2bc9c8) 91.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   91.34%   91.33%   -0.01%     
==========================================
  Files         126      126              
  Lines       32695    32714      +19     
==========================================
+ Hits        29865    29880      +15     
- Misses       2830     2834       +4
Files Coverage Δ
redis/client.py 92.05% <100.00%> (-0.08%) ⬇️
redis/cluster.py 92.84% <100.00%> (+0.02%) ⬆️
redis/commands/json/commands.py 89.55% <100.00%> (ø)
tests/test_json.py 99.80% <100.00%> (+<0.01%) ⬆️
redis/asyncio/client.py 92.03% <80.00%> (-0.12%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Repository owner closed this by deleting the head repository May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvora-h dvora-h Awaiting requested review from dvora-h

Assignees
No one assigned
Labels
bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in the decoding behavior when using client.json()
4 participants
@codecov-commenter @ghost @chayim @sxshx