Skip to content

Commit 876cf60

Browse files
authored
Do not offer incompatible Core versions for older ReScript versions (#50)
* Do not offer incompatible Core versions for older ReScript versions * Version 1.7.1 * Use Core 1.3.0
1 parent d5a1e85 commit 876cf60

File tree

8 files changed

+39
-25
lines changed

8 files changed

+39
-25
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "create-rescript-app",
3-
"version": "1.7.0",
3+
"version": "1.7.1",
44
"description": "Quickly create new ReScript apps from project templates.",
55
"main": "out/create-rescript-app.mjs",
66
"scripts": {
@@ -37,7 +37,7 @@
3737
},
3838
"devDependencies": {
3939
"@clack/prompts": "0.7.0",
40-
"@rescript/core": "^1.2.0",
40+
"@rescript/core": "^1.3.0",
4141
"@rollup/plugin-commonjs": "^25.0.7",
4242
"@rollup/plugin-node-resolve": "^15.2.3",
4343
"@rollup/plugin-terser": "^0.4.4",

src/RescriptVersions.res

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,15 @@ let getPackageVersions = async (packageName, range) => {
2323
versions
2424
}
2525

26+
let getCompatibleRescriptCoreVersions = (~rescriptVersion, ~rescriptCoreVersions) =>
27+
if CompareVersions.compareVersions(rescriptVersion, "11.1.0")->Ordering.isLess {
28+
rescriptCoreVersions->Array.filter(coreVersion =>
29+
CompareVersions.compareVersions(coreVersion, "1.3.0")->Ordering.isLess
30+
)
31+
} else {
32+
rescriptCoreVersions
33+
}
34+
2635
let promptVersions = async () => {
2736
let s = P.spinner()
2837

@@ -44,6 +53,11 @@ let promptVersions = async () => {
4453
})->P.resultOrRaise
4554
}
4655

56+
let rescriptCoreVersions = getCompatibleRescriptCoreVersions(
57+
~rescriptVersion,
58+
~rescriptCoreVersions,
59+
)
60+
4761
let rescriptCoreVersion = switch rescriptCoreVersions {
4862
| [version] => version
4963
| _ =>

templates/rescript-template-basic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"author": "",
1313
"license": "MIT",
1414
"dependencies": {
15-
"@rescript/core": "^1.2.0",
15+
"@rescript/core": "^1.3.0",
1616
"rescript": "^11.1.0"
1717
}
1818
}

templates/rescript-template-nextjs/package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/rescript-template-nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"author": "Patrick Ecker <[email protected]>",
55
"license": "Apache-2.0",
66
"dependencies": {
7-
"@rescript/core": "^1.2.0",
7+
"@rescript/core": "^1.3.0",
88
"@rescript/react": "^0.12.1",
99
"next": "^14.0.4",
1010
"react": "^18.2.0",

templates/rescript-template-vite/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/rescript-template-vite/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"preview": "vite preview"
1313
},
1414
"dependencies": {
15-
"@rescript/core": "^1.2.0",
15+
"@rescript/core": "^1.3.0",
1616
"@rescript/react": "^0.12.1",
1717
"react": "^18.2.0",
1818
"react-dom": "^18.2.0",

0 commit comments

Comments
 (0)