Skip to content

Commit 8f9ccd5

Browse files
committed
Revert "Use execFile instead of exec to fix Windows path issue (#59)"
This reverts commit 115fa1d.
1 parent 94b5854 commit 8f9ccd5

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/NewProject.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ let createProject = async (~templateName, ~projectName, ~versions) => {
6969
await updateRescriptJson(~projectName, ~versions)
7070

7171
await RescriptVersions.installVersions(versions)
72-
let _ = await Promisified.ChildProcess.execFile("git", ["init"])
72+
let _ = await Promisified.ChildProcess.exec("git init")
7373

7474
if !CI.isRunningInCI {
7575
s->P.Spinner.stop("Project created.")

src/RescriptVersions.res

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ let promptVersions = async () => {
6666
let installVersions = async ({rescriptVersion, rescriptCoreVersion}) => {
6767
let packageManager = PackageManagers.getActivePackageManager()
6868
let packages = [`rescript@${rescriptVersion}`, `@rescript/core@${rescriptCoreVersion}`]
69+
let command = `${packageManager} add ${packages->Array.join(" ")}`
6970

70-
let _ = await Node.Promisified.ChildProcess.execFile(packageManager, ["add", ...packages])
71+
let _ = await Node.Promisified.ChildProcess.exec(command)
7172
}
7273

7374
let esmModuleSystemName = ({rescriptVersion}) =>

src/bindings/Node.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,6 @@ module Promisified = {
8585
type execResult = {stdout: string, stderr: string}
8686

8787
@module("./NodePromisified.mjs")
88-
external execFile: (string, array<string>) => promise<execResult> = "execFile"
88+
external exec: string => promise<execResult> = "exec"
8989
}
9090
}

src/bindings/NodePromisified.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { execFile as execFileCallback } from "child_process";
1+
import { exec as execCallback } from "child_process";
22
import { promisify } from "util";
33

4-
export const execFile = promisify(execFileCallback);
4+
export const exec = promisify(execCallback);

0 commit comments

Comments
 (0)