Skip to content

Commit 08db9a8

Browse files
committed
stricter types on object.is, must be same
test updates
1 parent 5dec67f commit 08db9a8

File tree

2 files changed

+3
-33
lines changed

2 files changed

+3
-33
lines changed

test/ObjectTests.mjs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,6 @@ import * as Caml_obj from "rescript/lib/es6/caml_obj.js";
55

66
var eq = Caml_obj.equal;
77

8-
Test.run([
9-
[
10-
"ObjectTests.res",
11-
7,
12-
20,
13-
41
14-
],
15-
"is: different types"
16-
], Object.is("abc", false), eq, false);
17-
188
Test.run([
199
[
2010
"ObjectTests.res",
@@ -75,26 +65,6 @@ Test.run([
7565
"is: null and undefined"
7666
], Object.is(null, null), eq, true);
7767

78-
Test.run([
79-
[
80-
"ObjectTests.res",
81-
17,
82-
20,
83-
44
84-
],
85-
"is: null and undefined"
86-
], Object.is(null, undefined), eq, false);
87-
88-
Test.run([
89-
[
90-
"ObjectTests.res",
91-
18,
92-
20,
93-
44
94-
],
95-
"is: undefined and None"
96-
], Object.is(undefined, undefined), eq, true);
97-
9868
var nums = [
9969
1,
10070
2,

test/ObjectTests.res

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ let eq = (a, b) => a == b
44

55
// ===== is =====
66

7-
Test.run(__POS_OF__("is: different types"), Object.is("abc", false), eq, false)
7+
// Test.run(__POS_OF__("is: different types"), Object.is("abc", false), eq, false)
88

99
Test.run(__POS_OF__("is: ints"), Object.is(25, 25), eq, true)
1010

@@ -14,8 +14,8 @@ Test.run(__POS_OF__("is: strings"), Object.is("abc", "ABC"), eq, false)
1414
Test.run(__POS_OF__("is: null and undefined"), Object.is(null, undefined), eq, false)
1515
Test.run(__POS_OF__("is: null and undefined"), Object.is(undefined, undefined), eq, true)
1616
Test.run(__POS_OF__("is: null and undefined"), Object.is(null, null), eq, true)
17-
Test.run(__POS_OF__("is: null and undefined"), Object.is(null, None), eq, false)
18-
Test.run(__POS_OF__("is: undefined and None"), Object.is(undefined, None), eq, true) // hmmm...
17+
// Test.run(__POS_OF__("is: null and undefined"), Object.is(null, None), eq, false)
18+
// Test.run(__POS_OF__("is: undefined and None"), Object.is(undefined, None), eq, true)
1919

2020
let nums = [1, 2, 3]
2121
Test.run(__POS_OF__("is: arrays"), Object.is([1, 2, 3], [1, 2, 3]), eq, false)

0 commit comments

Comments
 (0)