Skip to content

Commit 0dbf4b3

Browse files
committed
remove unsafe Array.from functions
1 parent 1283825 commit 0dbf4b3

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
- The globally available `null` value now originates from `Nullable` and not `Null`, just like the globally available `undefined` value does. https://github.com/rescript-association/rescript-core/pull/88
2727
- Add `Int.range` and `Int.rangeWithOptions`, https://github.com/rescript-association/rescript-core/pull/52
2828
- Remove `Array.fromIterator` and `Array.fromIteratorWithMap`. The same functions exist in `Iterator` as `Iterator.fromArray` and `Iterator.fromArrayWithMapper`. https://github.com/rescript-association/rescript-core/pull/78
29+
- Remove unsafe `Array.from` and `Array.fromWithMap`. https://github.com/rescript-association/rescript-core/pull/78
2930

3031
### Documentation
3132

src/Core__Array.res

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
external getUnsafe: (array<'a>, int) => 'a = "%array_unsafe_get"
44
external setUnsafe: (array<'a>, int, 'a) => unit = "%array_unsafe_set"
55

6-
@val external from: 'a => array<'b> = "Array.from"
7-
@val external fromWithMap: ('a, 'b => 'c) => array<'c> = "Array.from"
8-
96
@val external fromArrayLike: Js.Array2.array_like<'a> => array<'a> = "Array.from"
107
@val
118
external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"

src/Core__Array.resi

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
@val external from: 'a => array<'b> = "Array.from"
2-
@val external fromWithMap: ('a, 'b => 'c) => array<'c> = "Array.from"
31
@val external fromArrayLike: Js.Array2.array_like<'a> => array<'a> = "Array.from"
42
@val
53
external fromArrayLikeWithMap: (Js.Array2.array_like<'a>, 'a => 'b) => array<'b> = "Array.from"

0 commit comments

Comments
 (0)