feat(Intl.DateTimeFormat): strongly typed options

Author: glennsl

src/intl/Core__Intl__DateTimeFormat.res

@@ -1,18 +1,41 @@
 type t
 
+type options = {
+  localeMathcer?: [#lookup | #"best fit"],
+  calendar?: string,
+  numberingSystem?: string,
+  hour12?: bool,
+  hourCycle?: [#h11 | #h12 | #h23 | #h24],
+  timeZone?: string,
+  weekday?: [#long | #short | #narrow],
+  era?: [#long | #short | #narrow],
+  year?: [#numeric | #"2-digit"],
+  month?: [#numeric | #"2-digit" | #long | #short | #narrow],
+  day?: [#numeric | #"2-digit"],
+  dayPeriod?: [#long | #short | #narrow],
+  hour?: [#numeric | #"2-digit"],
+  minute?: [#numeric | #"2-digit"],
+  second?: [#numeric | #"2-digit"],
+  fractionalSecondDigits?: int,
+  timeZoneName?: [#long | #short | #shortOffset | #longOffset | #shortGeneric | #longGeneric],
+  formatMatcher?: [#basic | #"best fit"],
+  dateStyle?: [#full | #long | #medium | #short],
+  timeStyle?: [#full | #long | #medium | #short],
+}
+
 @new external make: unit => t = "Intl.DateTimeFormat"
 @new external makeWithLocale: string => t = "Intl.DateTimeFormat"
 @new external makeWithLocales: array<string> => t = "Intl.DateTimeFormat"
-@new external makeWithLocaleAndOptions: (string, {..}) => t = "Intl.DateTimeFormat"
-@new external makeWithLocalesAndOptions: (array<string>, {..}) => t = "Intl.DateTimeFormat"
-@new external makeWithOptions: (@as(json`undefined`) _, {..}) => t = "Intl.DateTimeFormat"
+@new external makeWithLocaleAndOptions: (string, options) => t = "Intl.DateTimeFormat"
+@new external makeWithLocalesAndOptions: (array<string>, options) => t = "Intl.DateTimeFormat"
+@new external makeWithOptions: (@as(json`undefined`) _, options) => t = "Intl.DateTimeFormat"
 
 @val external supportedLocalesOf: array<string> => t = "Intl.DateTimeFormat.supportedLocalesOf"
 @val
-external supportedLocalesOfWithOptions: (array<string>, {..}) => t =
+external supportedLocalesOfWithOptions: (array<string>, options) => t =
   "Intl.DateTimeFormat.supportedLocalesOf"
 
-@send external resolvedOptions: t => {..} = "resolvedOptions"
+@send external resolvedOptions: t => options = "resolvedOptions"
 
 @send external format: (t, Core__Date.t) => string = "format"
 @send

test/TempTests.mjs

@@ -109,6 +109,10 @@ console.log(Intl.NumberFormat.supportedLocalesOf([
 
 console.log(currencyFormatter.format(123.23));
 
+var resolvedOptions = new Intl.DateTimeFormat().resolvedOptions();
+
+console.log(resolvedOptions.timeZone);
+
 console.info("");
 
 console.info("JSON");
@@ -306,10 +310,6 @@ if (globalThis.hello !== undefined) {
   console.log("hello");
 }
 
-var resolvedOptions = new Intl.DateTimeFormat().resolvedOptions();
-
-var timeZone = resolvedOptions.timeZone;
-
 var z = 1.2 % 1.4;
 
 var intFromBigInt = Core__BigInt.toInt(BigInt("10000000000"));
@@ -336,6 +336,7 @@ export {
   dict2 ,
   f ,
   currencyFormatter ,
+  resolvedOptions ,
   json ,
   map ,
   myObject ,
@@ -350,8 +351,6 @@ export {
   x ,
   array$1 as array,
   timeout ,
-  resolvedOptions ,
-  timeZone ,
   z ,
   intFromBigInt ,
   Bugfix ,

test/TempTests.res

@@ -51,6 +51,8 @@ let currencyFormatter = Intl.NumberFormat.makeWithLocaleAndOptions(
 
 Console.log(Intl.NumberFormat.supportedLocalesOf(["fr-FR", "en-US"]))
 Console.log(currencyFormatter->Intl.NumberFormat.format(123.23))
+let resolvedOptions = Intl.DateTimeFormat.make()->Intl.DateTimeFormat.resolvedOptions
+Console.log(resolvedOptions.timeZone)
 
 Console.info("")
 Console.info("JSON")
@@ -191,9 +193,6 @@ if globalThis["hello"] !== undefined {
   Console.log("hello")
 }
 
-let resolvedOptions = Intl.DateTimeFormat.make()->Intl.DateTimeFormat.resolvedOptions
-let timeZone = resolvedOptions["timeZone"]
-
 let z = Float.mod(1.2, 1.4)
 
 let intFromBigInt = BigInt.fromString("10000000000")->BigInt.toInt