refactor

Author: zth

analysis/src/TypeUtils.ml

@@ -1183,8 +1183,7 @@ let transformCompletionToPipeCompletion ?(synthetic = false) ~env ?posOfDot
     of the project. Example: type x in module SomeModule in file SomeFile would get the globally 
     unique id `SomeFile.SomeModule.x`.*)
 let rec findRootTypeId ~full ~env (t : Types.type_expr) =
-  let debug = Debug.verbose () in
-  (* let debug = false in *)
+  let debug = false in
   match t.desc with
   | Tlink t1 | Tsubst t1 | Tpoly (t1, []) -> findRootTypeId ~full ~env t1
   | Tconstr (Pident {name = "function$"}, [t; _], _) ->

analysis/tests/src/DotCompletionEverywhere.res

@@ -114,3 +114,33 @@ let outOfScope = (t: typeOutsideModule) => t
 
 // @editor.completeFrom([CompletionPipe, Dot]) type t
 //                                          ^com
+
+let someObj = {
+  "name": "hello",
+  "age": 123,
+}
+
+// someObj.
+//         ^com
+
+// someObj.na
+//           ^com
+
+module DOMAPI = {
+  type htmlElement = {prefix: string}
+
+  @editor.completeFrom(DotPipeCompletionSpec.HTMLButtonElement)
+  type rec htmlButtonElement = {mutable disabled: bool}
+}
+
+module HTMLButtonElement = {
+  open DOMAPI
+
+  @send
+  external checkValidity: htmlButtonElement => bool = "checkValidity"
+}
+
+external button: DOMAPI.htmlButtonElement = "button"
+
+// button.
+//        ^com