File tree 2 files changed +10
-5
lines changed
2 files changed +10
-5
lines changed Original file line number Diff line number Diff line change 1
1
## 1.0.x (unreleased)
2
2
- Fix diagnostics when location's not found (advice: use fewer ppxes!). See [ #77 ] ( https://github.com/rescript-lang/rescript-vscode/issues/77 ) .
3
+ - Fix request failing when there's a white space in the project path.
3
4
4
5
## 1.0.5
5
6
Original file line number Diff line number Diff line change @@ -19,7 +19,11 @@ let findExecutable = (uri: string) => {
19
19
if ( projectRootPath == null || ! binaryExists ) {
20
20
return null ;
21
21
} else {
22
- return { binaryPath, filePath, cwd : projectRootPath } ;
22
+ return {
23
+ binaryPathQuoted : '"' + binaryPath + '"' , // path could have white space
24
+ filePathQuoted : '"' + filePath + '"' ,
25
+ cwd : projectRootPath ,
26
+ } ;
23
27
}
24
28
} ;
25
29
@@ -34,9 +38,9 @@ export function runDumpCommand(
34
38
onResult ( null ) ;
35
39
} else {
36
40
let command =
37
- executable . binaryPath +
41
+ executable . binaryPathQuoted +
38
42
" dump " +
39
- executable . filePath +
43
+ executable . filePathQuoted +
40
44
":" +
41
45
msg . params . position . line +
42
46
":" +
@@ -65,9 +69,9 @@ export function runCompletionCommand(
65
69
fs . writeFileSync ( tmpname , code , { encoding : "utf-8" } ) ;
66
70
67
71
let command =
68
- executable . binaryPath +
72
+ executable . binaryPathQuoted +
69
73
" complete " +
70
- executable . filePath +
74
+ executable . filePathQuoted +
71
75
":" +
72
76
msg . params . position . line +
73
77
":" +
You can’t perform that action at this time.
0 commit comments